Skip to content

vendor: add missing containerd/cgroups dependency - #2329

Merged
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:add_missing_vendor
Feb 12, 2020
Merged

vendor: add missing containerd/cgroups dependency#2329
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:add_missing_vendor

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

This dependency is references in the hcsshim package, but
was not added when hcsshim was updated in dff269b (#2242)

The missing dependency was printed as a warning by vndr:

WARNING: dependency is not vendored: github.com/containerd/cgroups/stats/v1

But somehow didn't get noticed in CI (possibly because our "make cross" builds
multiple targets, and a single failure isn't noticed?)

This dependency is references in the hcsshim package, but
was not added when hcsshim was updated in dff269b
The missing dependency was printed as a warning by vndr:
WARNING: dependency is not vendored: github.com/containerd/cgroups/stats/v1
But somehow didn't get noticed in CI (possibly because our "make cross" builds
multiple targets, and a single failure isn't noticed?)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit e6ea7c2 into docker:masterFeb 12, 2020
@thaJeztah
thaJeztah deleted the add_missing_vendor branch February 12, 2020 17:25
@thaJeztahthaJeztah added this to the 20.03.0 milestone Feb 19, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@silvin-lubecki@GordonTheTurtle