Uh oh!
There was an error while loading. Please reload this page.
Build stdin with compress - #233
Conversation
fc176bf to
0c950feCompareCodecov Report
@@ Coverage Diff @@## master #233 +/- ##
==========================================
+ Coverage 46.98% 48.33% +1.34%
==========================================
Files 172 172 Lines 11693 11710 +17 ==========================================
+ Hits 5494 5660 +166 + Misses 5882 5692 -190 - Partials 317 358 +41 |
tonistiigi
commented
Jun 23, 2017
0c950fe LGTM Could move that compress function to the |
thaJeztah
commented
Jun 27, 2017
I'm removing this from the 17.06.1 milestone; the refactoring taken from #227 probably are not needed for 17.06.1, so if we need just the fix, we may need a different implementation for the 17.06 branch (let me know if you don't agree though 😃 ) |
dnephin
commented
Jun 27, 2017
There is no way to test this properly without the refactoring. So if we want the fix I think we need to take the refactoring as well. |
thaJeztah
commented
Jun 27, 2017
I opened an internal issue for discussing; we need to outweigh the importance of this fix against the amount of changes required 👍 |
0c950fe to
337bcddComparednephin
commented
Jun 29, 2017
rebased |
337bcdd to
f7f567fCompareWrite a test showing compress failure. Signed-off-by: Daniel Nephin <dnephin@docker.com>
f7f567f to
a04aa8fCompare…k-logger [17.09] Fixed `raw` mode splunk logger
Compress after the archive is rewritten.