Skip to content

[19.03 backport] bump gotest.tools v3.0.1 for compatibility with Go 1.14 - #2456

Merged
silvin-lubecki merged 3 commits into
docker:19.03from
thaJeztah:19.03_backport_gotest_v3
Apr 21, 2020
Merged

[19.03 backport] bump gotest.tools v3.0.1 for compatibility with Go 1.14#2456
silvin-lubecki merged 3 commits into
docker:19.03from
thaJeztah:19.03_backport_gotest_v3

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Apr 20, 2020

Copy link
Copy Markdown
Member

backport of #2328 and #2358 for 19.03.

Also included the first commit from #2275

full diff: gotestyourself/gotest.tools@v2.3.0...v3.0.1

With this change, go packages/modules that use versioned
import paths (github.com/foo/bar/v2), but don't use a directory
in the repository, can now be supported.
For example:
```
github.com/coreos/go-systemd/v22 v22.0.0
```
will vendor the github.com/coreos/go-systemd repository
into `vendor/github.com/coreos/go-systemd/v22`.
full diff: LK4D4/vndr@b177b58...v0.1.0
- LK4D4/vndr#79 Add more clear messages around clone failures
- LK4D4/vndr#80 add riscv64 support
- LK4D4/vndr#83 migrate bitbucket to api 2.0
- fixesLK4D4/vndr#82https://api.bitbucket.org/1.0/repositories/ww/goautoneg: 410 Gone
- LK4D4/vndr#86 Replace sort.Sort with sort.Strings
- LK4D4/vndr#87 support `github.com/coreos/go-systemd/v22`
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 7904c23)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: LK4D4/vndr@v0.1.0...v0.1.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 7c54406)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the 19.03_backport_gotest_v3 branch 2 times, most recently from 676d6ce to d13a525CompareApril 20, 2020 21:03
@thaJeztahthaJeztah changed the title bump gotest.tools v3.0.1 for compatibility with Go 1.14[19.03 backport] bump gotest.tools v3.0.1 for compatibility with Go 1.14Apr 21, 2020
full diff: gotestyourself/gotest.tools@v2.3.0...v3.0.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 2c0e930)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the 19.03_backport_gotest_v3 branch from d13a525 to 4fe6b83CompareApril 21, 2020 14:43
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

I had to make some manual find/replace changes, because 19.03 still has the docker engine activate code in (which was already removed on master when this was merged); CI is green now, so I think it should be good to go

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit 8986e31 into docker:19.03Apr 21, 2020
@thaJeztah
thaJeztah deleted the 19.03_backport_gotest_v3 branch April 21, 2020 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah@silvin-lubecki