Skip to content

[19.03 backport] assorted docs fixes - #2469

Merged
thaJeztah merged 2 commits into
docker:19.03from
thaJeztah:19.03_backport_docs
Apr 28, 2020
Merged

[19.03 backport] assorted docs fixes#2469
thaJeztah merged 2 commits into
docker:19.03from
thaJeztah:19.03_backport_docs

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Apr 28, 2020

Copy link
Copy Markdown
Member

backports of:

dominikbraunand others added 2 commits April 28, 2020 11:47
@dominikbraun@thaJeztah
Add container_iface_prefix option to documentation
2dc593f
Signed-off-by: dominikbraun <braun@sternentstehung.de>
(cherry picked from commit 84a07a9)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
service update: fix service create example
0cfe294
Service create expects the name to be passed using the
`--name` flag, not as a positional parameter
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 0cd7c6a)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 19.03.9 milestone Apr 28, 2020
silvin-lubecki
silvin-lubecki approved these changes Apr 28, 2020
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah merged commit e470eef into docker:19.03Apr 28, 2020
@thaJeztah
thaJeztah deleted the 19.03_backport_docs branch April 28, 2020 10:02
@thaJeztahthaJeztah mentioned this pull request Apr 28, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silvin-lubeckisilvin-lubeckisilvin-lubecki approved these changes

Assignees

No one assigned

Labels

kind/docsstatus/3-docs-review

Projects

None yet

Milestone

19.03.9

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@silvin-lubecki@dominikbraun