Skip to content

Add support for --limit-pids on service create / update and stacks (swarm) - #2503

Merged
silvin-lubecki merged 2 commits into
docker:masterfrom
thaJeztah:pidslimit
Jun 22, 2020
Merged

Add support for --limit-pids on service create / update and stacks (swarm)#2503
silvin-lubecki merged 2 commits into
docker:masterfrom
thaJeztah:pidslimit

Conversation

@thaJeztah

@thaJeztahthaJeztah commented May 7, 2020

Copy link
Copy Markdown
Member

depends on:

relates to:

docker-compose / stack support was not yet added; I'll try to get that done asap

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@silvin-lubecki PTAL

@cpuguy83cpuguy83 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

We're discussing changing the API to move the PidsLimit to the Resources section; I'll try to get that done today/tomorow so that we don't have to change the API after 20.0x code-freeze

@thaJeztah
thaJeztah marked this pull request as draft May 7, 2020 20:17
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

(moved to "draft" meanwhile)

@albersalbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash completion LGTM

@thaJeztah
thaJeztahforce-pushed the pidslimit branch 3 times, most recently from 5e93453 to 9620753CompareJune 15, 2020 11:52
@thaJeztahthaJeztah changed the title Add support for --pids-limit on service create / service updateAdd support for --limit-pids on service create / update and stacks (swarm)Jun 15, 2020
@thaJeztah
thaJeztahforce-pushed the pidslimit branch 2 times, most recently from 8136289 to 0c10d08CompareJune 15, 2020 12:05
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #2503 into master will increase coverage by 0.06%.
The diff coverage is 85.00%.

@@ Coverage Diff @@## master #2503 +/- ##
==========================================
+ Coverage 58.05% 58.12% +0.06% 
==========================================
Files 295 295 Lines 21165 21182 +17 ==========================================
+ Hits 12288 12311 +23 + Misses 7975 7967 -8 - Partials 902 904 +2 

@thaJeztah
thaJeztah marked this pull request as ready for review June 18, 2020 19:39
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@silvin-lubecki@cpuguy83 updated this one with the API changes, and renamed --pids-limit to --limit-pids, so that it matches the other limits for services PTAL

@cpuguy83cpuguy83 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albersalbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated completion LGTM

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security Proposal: add "--pids-limit" to "docker service create/update" option list

5 participants

@thaJeztah@codecov-commenter@cpuguy83@albers@silvin-lubecki