Uh oh!
There was an error while loading. Please reload this page.
Add checks for dependencies that are not vendored - #2596
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
thaJeztah
left a comment
There was a problem hiding this comment.
thanks! left two minor nits
could you also
- squash the commits, so that there's a single commit in this PR
- use a descriptive first line for the commit description (e.g. "Add check for dependencies that are not vendored")
- remove the #2332 from the commit message; I know this is often recommended, but having that reference in the commit message can create a lot of noise on GitHub (if forks of this project merge/cherry-pick the commit etc). Having the reference in the PR description on github is sufficient
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Madhur1997
commented
Jun 25, 2020
Thanks for the review @thaJeztah. |
Madhur1997
commented
Jul 6, 2020
Hey @thaJeztah Wanted to know if there is any other review comment or am I missing anything here? |
silvin-lubecki
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot @Madhur1997
`make vendor` fails if any dependency is not vendored. Signed-off-by: Madhur Batra <madhurbatra097@gmail.com>
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
whoops, sorry, thought I LGTM'd already 😅
Signed-off-by: Madhur Batra madhurbatra097@gmail.com
- What I did
Fix#2332:
make vendornow regards 'WARNING: dependency is not vendored' as anerror and fails when some non vendored dependencies exist.
- How I did it
Added a new validation script that runs against the
vndroutput to find any'WARNING: dependency is not vendored' line. If found script exits with non zero status.
- How to verify it
Added a new import in a go file, and ran go get to install the same in GOPATH.
Now
vndr checkfailed due to unvendored dependency.- Description for the changelog
Enhanced existing Makefile to store the
vndrlogs in a tmp file.Ran a new script against the log to verify that there is no unvendored dependency.
- A picture of a cute animal (not mandatory but encouraged)