Uh oh!
There was an error while loading. Please reload this page.
Fixes #2753 - add case-insensitive auth - #2782
Closed
piotrowski wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Aleksander Piotrowski <apiotrowski312@gmail.com>
codecov-io
commented
Oct 11, 2020
Codecov Report
@@ Coverage Diff @@## master #2782 +/- ##
==========================================
- Coverage 57.14% 57.14% -0.01%
==========================================
Files 297 297 Lines 18634 18636 +2 ==========================================
+ Hits 10649 10650 +1 - Misses 7126 7127 +1
Partials 859 859 |
hc0503
approved these changes
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#2753
- What I did
I fixed the issue with case sensitive authorization. Now it is case-insensitive.
- How I did it
I added
strings.ToLower()in few places.I refactored
RunPush()function a little so now it is using the sameAuthResolver()function asRunPull().- How to verify it
I tested it on local registry with basicAuth.
I tested login and logout, push and pull images.
I did test push/pull for not lower cased images and that was working fine too.
- Description for the changelog
Makes authentication case-insensitive
- A picture of a cute animal (not mandatory but encouraged)
