Skip to content

Always enable experimental features in bash completion - #2837

Merged
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion-remove-experimental-client
Nov 10, 2020
Merged

Always enable experimental features in bash completion#2837
thaJeztah merged 1 commit into
docker:masterfrom
albers:completion-remove-experimental-client

Conversation

@albers

Copy link
Copy Markdown
Collaborator

This amends #2774 for bash completion.

docker manifest now ist always completed.

The previous state parsed the output of docker version to determine the cli experimental state.

This amends docker#2774 for bash completion.
Signed-off-by: Harald Albers <github@albersweb.de>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thanks; I completely forgot 😞

@thaJeztah

Copy link
Copy Markdown
Member

Failure is unrelated;

cli/command/container/stats.go:159: File is not `goimports`-ed (goimports)

will be fixed by #2836

@thaJeztahthaJeztah added this to the 20.10.0 milestone Nov 10, 2020
@thaJeztah
thaJeztah merged commit 92516c7 into docker:masterNov 10, 2020
@albers
albers deleted the completion-remove-experimental-client branch November 11, 2020 08:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@albers@thaJeztah