Skip to content

Added docker context to zsh completion - #2906

Merged
thaJeztah merged 2 commits into
docker:masterfrom
stoffus:added-docker-context-to-zsh-completion
Jan 11, 2021
Merged

Added docker context to zsh completion#2906
thaJeztah merged 2 commits into
docker:masterfrom
stoffus:added-docker-context-to-zsh-completion

Conversation

@stoffus

Copy link
Copy Markdown
Contributor

- What I did

Added zsh completion for the docker context subcommands.

- How I did it

Followed the convention of the other completions.

- How to verify it

  1. Replace the content of the current _docker plugin (most likely located in ~/.oh-my-zsh/plugins/docker/_docker for Oh My Zsh users).
  2. If not already present, append the docker plugin in your .zshrc, e.g. plugins=(git mvn docker).
  3. Reload zsh with source ~/.zshrc.
  4. The plugin should now include the new context subcommands, e.g. docker context use <tab>.

- Description for the changelog
Added zsh completion for docker context subcommands.

- A picture of a cute animal (not mandatory but encouraged)

uggla-2

Signed-off-by: Christopher Svensson <stoffus@stoffus.com>
Signed-off-by: Christopher Svensson <stoffus@stoffus.com>
@stoffus
stoffusforce-pushed the added-docker-context-to-zsh-completion branch from fb412ec to b04241dCompareJanuary 5, 2021 07:29
@codecov-io

codecov-io commented Jan 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2906 (b04241d) into master (2291f61) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2906 +/- ##
=======================================
Coverage 57.05% 57.05% =======================================
Files 297 297 Lines 18653 18653 =======================================
Hits 10643 10643 Misses 7151 7151 Partials 859 859 

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @stoffus 👍 I works well on my zsh 🚀

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@stoffus@codecov-io@thaJeztah@silvin-lubecki