Skip to content

deprecate blkio-weight options with cgroups v1 - #2908

Merged
tiborvass merged 1 commit into
docker:masterfrom
thaJeztah:deprecate_blkio_weight
Jan 7, 2021
Merged

deprecate blkio-weight options with cgroups v1#2908
tiborvass merged 1 commit into
docker:masterfrom
thaJeztah:deprecate_blkio_weight

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Jan 4, 2021•
edited
Loading

Copy link
Copy Markdown
Member

relates to moby/moby#41252 (comment)

These options were deprecated and removed in the Linux kernel v5.0 and up in;

- Description for the changelog

- Deprecate blkio-weight options with cgroups v1

@thaJeztah

thaJeztah commented Jan 4, 2021

Copy link
Copy Markdown
MemberAuthor

@AkihiroSuda perhaps you could have a look; I'm somewhat confused what's deprecated, and what not (and/or if this has already been removed?). Looking at https://github.com/torvalds/linux/blob/fb5772cbfe48575711bf789767d561582376f7f1/Documentation/cgroup-v1/blkio-controller.txt#L91-L97 these are still listed

Are they still functional? Only with v2, or also with v1, or have they been fully removed?

Do we need to update the checks we use to print the warnings (as shown in docker/for-linux#1175)?

@thaJeztah

thaJeztah commented Jan 4, 2021

Copy link
Copy Markdown
MemberAuthor

Do you also know which kernel version this was deprecated / removed in?

@AkihiroSuda

AkihiroSuda commented Jan 7, 2021

Copy link
Copy Markdown
Collaborator

blkio.weight was removed in kernel 5.0: torvalds/linux@f382fb0

cgroup v2 still has io.weight which can be converted from blkio.weight

AkihiroSuda
AkihiroSuda reviewed Jan 7, 2021
View reviewed changes
Comment threaddocs/deprecated.md Outdated

Specifying blkio weight (`docker run --blkio-weight` and `docker run --blkio-weight-device`)
is now marked as deprecated when using cgrous v1, because the corresponding features
were marked [deprecated in the Linux kernel](https://github.com/torvalds/linux/commit/f382fb0bcef4c37dc049e9f6963e3baf204d815c).

@AkihiroSudaAkihiroSudaJan 7, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/deprecated/removed/

@thaJeztah

thaJeztah commented Jan 7, 2021

Copy link
Copy Markdown
MemberAuthor

blkio.weight was removed in kernel 5.0: torvalds/linux@f382fb0

Should it be removed from this page? https://github.com/torvalds/linux/blob/23aa16489c06e6739c7c99e9fdccf723d2691a5d/Documentation/admin-guide/cgroup-v1/blkio-controller.rst#proportional-weight-policy-files or is that expected to still be there (and converted to io.weight) ?

@thaJeztah

thaJeztah commented Jan 7, 2021

Copy link
Copy Markdown
MemberAuthor

cgroup v2 still has io.weight which can be converted from blkio.weight

Do we need to make changes on our side to perform that conversion? (Haven't checked)

@thaJeztah
deprecate blkio-weight options with cgroups v1
fb2ea09
These options were deprecated and removed in the Linux kernel v5.0 and up in;
- torvalds/linux@f382fb0
- torvalds/linux@fb5772c
- torvalds/linux@23aa164
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the deprecate_blkio_weight branch from 30f6aa7 to fb2ea09CompareJanuary 7, 2021 10:29
@thaJeztah

thaJeztah commented Jan 7, 2021

Copy link
Copy Markdown
MemberAuthor

updated; PTAL (hope the description of the io.weight part is correct, happy to update otherwise

@codecov-io

codecov-io commented Jan 7, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2908 (fb2ea09) into master (2291f61) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2908 +/- ##
=======================================
Coverage 57.05% 57.05% =======================================
Files 297 297 Lines 18653 18653 =======================================
Hits 10643 10643 Misses 7151 7151 Partials 859 859

@AkihiroSuda

AkihiroSuda commented Jan 7, 2021

Copy link
Copy Markdown
Collaborator

Should it be removed from this page? https://github.com/torvalds/linux/blob/23aa16489c06e6739c7c99e9fdccf723d2691a5d/Documentation/admin-guide/cgroup-v1/blkio-controller.rst#proportional-weight-policy-files

Seems yes

conversion

Conversion is done by runc, not by kernel nor Moby

@thaJeztah

thaJeztah commented Jan 7, 2021

Copy link
Copy Markdown
MemberAuthor

Conversion is done by runc, not by kernel nor Moby

Thanks Akihiro! (sorry for all the questions 😅)

@thaJeztahthaJeztah added this to the 20.10.3 milestone Jan 7, 2021
@thaJeztah

thaJeztah commented Jan 7, 2021

Copy link
Copy Markdown
MemberAuthor

@silvin-lubecki PTAL

@tiborvass
tiborvass merged commit c6493c7 into docker:masterJan 7, 2021
@thaJeztah
thaJeztah deleted the deprecate_blkio_weight branch January 7, 2021 19:27
cpuguy83
cpuguy83 approved these changes Jan 7, 2021
View reviewed changes

@cpuguy83cpuguy83 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

silvin-lubecki
silvin-lubecki reviewed Jan 8, 2021
View reviewed changes
Comment threaddocs/deprecated.md
**Deprecated in Release: v20.10**

Specifying blkio weight (`docker run --blkio-weight` and `docker run --blkio-weight-device`)
is now marked as deprecated when using cgrous v1 because the corresponding features

@silvin-lubeckisilvin-lubeckiJan 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little typo: cgrous cgroups

@thaJeztahthaJeztahJan 8, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arf, thx

@thaJeztahthaJeztah mentioned this pull request Jan 8, 2021
Merged
@thaJeztahthaJeztah modified the milestones: 20.10.3, 20.10.4Feb 2, 2021
@thaJeztahthaJeztah modified the milestones: 20.10.4, 21.xxFeb 4, 2021
@thaJeztahthaJeztah mentioned this pull request Feb 4, 2021
Merged
@FuristoFuristo mentioned this pull request May 24, 2021
Merged
@dankingdanking mentioned this pull request May 27, 2021
Merged
@swagatbora90swagatbora90 mentioned this pull request Mar 12, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silvin-lubeckisilvin-lubeckisilvin-lubecki left review comments
@cpuguy83cpuguy83cpuguy83 approved these changes
@AkihiroSudaAkihiroSudaAkihiroSuda approved these changes
+1 more reviewer
@tiborvasstiborvasstiborvass approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

impact/changelogimpact/deprecationkind/docsprocess/cherry-pickedstatus/3-docs-review

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah@AkihiroSuda@codecov-io@cpuguy83@tiborvass@silvin-lubecki