Skip to content

Remove duplicate word in push.md - #2915

Merged
thaJeztah merged 1 commit into
docker:masterfrom
rochfeu:patch-1
Jan 6, 2021
Merged

Remove duplicate word in push.md#2915
thaJeztah merged 1 commit into
docker:masterfrom
rochfeu:patch-1

Conversation

@rochfeu

Copy link
Copy Markdown
Contributor

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2915 (bb0cc9a) into master (2560cc6) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2915 +/- ##
=======================================
Coverage 57.05% 57.05% =======================================
Files 297 297 Lines 18653 18653 =======================================
Hits 10643 10643 Misses 7151 7151 Partials 859 859 

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Change itself looks good, but looks like the commit message is missing a DCO sign-off, which causes CI to fail; you can find instructions on how to fix this from the command-line (unfortunately, it's not possible to fix commit messages from the GitHub webUI 😞); https://github.com/docker/cli/pull/2915/checks?check_run_id=1655200518

When fixing, make sure to use your real name, not your GitHub handle/name; let me know if you need help making those changes, thanks!

Signed-off-by: Roch Feuillade <roch.feuillade@pandobac.com>
@rochfeu

Copy link
Copy Markdown
ContributorAuthor

When fixing, make sure to use your real name, not your GitHub handle/name; let me know if you need help making those changes, thanks!

I just did it but DCO CI fails and asks for my GitHub pseudo:

Commit sha: 69b5487, Author: rochfeu, Committer: Roch; Expected "rochfeu 46478807+rochfeu@users.noreply.github.com", but got "Roch Feuillade roch.feuillade@pandobac.com".

@thaJeztah

Copy link
Copy Markdown
Member

I just did it but DCO CI fails and asks for my GitHub pseudo:

Ah, yes, I think it may be checking against the name you have configure in your git config;

config user.name
Sebastiaan van Stijn

You can update your git config to match, which should fix that; https://github.com/moby/moby/blob/v20.10.0/docs/contributing/set-up-git.md#task-2-set-your-signature-and-an-upstream-remote

No no worries, I can manually mark it as "passed" for this case 👍

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rochfeu@codecov-io@thaJeztah@silvin-lubecki