Skip to content

[20.10 backport] Ignore SIGURG on Linux. - #2960

Merged
cpuguy83 merged 1 commit into
docker:20.10from
thaJeztah:20.10_backport_ignore_sigurg
Feb 4, 2021
Merged

[20.10 backport] Ignore SIGURG on Linux.#2960
cpuguy83 merged 1 commit into
docker:20.10from
thaJeztah:20.10_backport_ignore_sigurg

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

backport of #2929

In go1.14+, SIGURG is used by the runtime to handle preemtable system
calls.
In practice this signal is caught frequently.

For reference:

https://go.googlesource.com/proposal/+/master/design/24543-non-cooperative-preemption.md
golang/go#37942

In go1.14+, SIGURG is used by the runtime to handle preemtable system
calls.
In practice this signal caught *frequently*.
For reference:
https://go.googlesource.com/proposal/+/master/design/24543-non-cooperative-preemption.mdgolang/go#37942
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit fff164c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 20.10.4 milestone Feb 4, 2021
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@silvin-lubecki@cpuguy83 ptal

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2960 (3c87f01) into 20.10 (48d30b5) will increase coverage by 0.06%.
The diff coverage is 78.57%.

@@ Coverage Diff @@## 20.10 #2960 +/- ##
==========================================
+ Coverage 57.02% 57.08% +0.06% 
==========================================
Files 297 299 +2 Lines 18666 18676 +10 ==========================================
+ Hits 10644 10661 +17 + Misses 7157 7149 -8 - Partials 865 866 +1 

@cpuguy83
cpuguy83 merged commit 41b3ea7 into docker:20.10Feb 4, 2021
@thaJeztah
thaJeztah deleted the 20.10_backport_ignore_sigurg branch February 4, 2021 15:40
kaosagnt added a commit to kaosagnt/boot2docker-xfs-ng that referenced this pull request Mar 3, 2021
Revert docker/cli#2960 to fix hanging in docker start --attach and remove
spurious “Unsupported signal: . Discarding." messages
[docker/cli#2987](docker/cli#2987)
kaosagnt added a commit to kaosagnt/toolbox2docker that referenced this pull request Mar 3, 2021
https://docs.docker.com/engine/release-notes/
2021-03-02 Client
Revert docker/cli#2960 to fix hanging in docker start --attach and
remove spurious “Unsupported signal: . Discarding." messages docker/cli#2987
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-io@cpuguy83@silvin-lubecki