Skip to content

update go to 1.17 - #3258

Closed
tonistiigi wants to merge 1 commit into
docker:masterfrom
tonistiigi:go1.17
Closed

update go to 1.17#3258
tonistiigi wants to merge 1 commit into
docker:masterfrom
tonistiigi:go1.17

Conversation

@tonistiigi

Copy link
Copy Markdown
Member

Removes the platform-based switch between different versions.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Removes the platform based switch between different versions.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3258 (9de2e44) into master (e3dfc24) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #3258 +/- ##
=======================================
Coverage 57.99% 57.99% =======================================
Files 302 302 Lines 21748 21748 =======================================
Hits 12613 12613 Misses 8212 8212 Partials 923 923 

@thaJeztah

Copy link
Copy Markdown
Member

We should check if moby/moby also builds with go 1.17. The release pipeline currently assumes the same version is used for both

@thaJeztahthaJeztah mentioned this pull request Aug 19, 2021

@AkihiroSudaAkihiroSuda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 1.17 on macOS requires golang/sys@a76c4d0 (May 8) or later.

The current version in vendor.conf is golang/sys@d19ff85 (Apr 27)

@thaJeztah

Copy link
Copy Markdown
Member

opened moby/moby#42777 to test moby on go 1.17

@thaJeztah

Copy link
Copy Markdown
Member

opened #3269 to update golang.org/x/sys in this repository

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tonistiigi@codecov-commenter@thaJeztah@AkihiroSuda