Uh oh!
There was an error while loading. Please reload this page.
Fix test and lint failures on master - #326
Merged
Merged
Conversation
Split test cases. Signed-off-by: Daniel Nephin <dnephin@docker.com>
Codecov Report
@@ Coverage Diff @@## master #326 +/- ##
=========================================
Coverage ? 48.71% =========================================
Files ? 186 Lines ? 12413 Branches ? 0 =========================================
Hits ? 6047 Misses ? 5994 Partials ? 372 |
thaJeztah
commented
Jul 12, 2017
Member
ignoring codecov guess it's because master was broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the conflict between the changes in #299 and #277, which just merged together.
Also split up the test cases from #277