Uh oh!
There was an error while loading. Please reload this page.
ci: github actions validate workflow - #3381
Merged
Merged
Conversation
crazy-max
commented
Dec 8, 2021
MemberAuthor
This check fails because CircleCI config has been removed.
When this PR is merged we should remove the CircleCI integration in this repository. |
crazy-max
marked this pull request as ready for review
December 9, 2021 10:15
crazy-maxforce-pushed
the
gha-validate
branch
2 times, most recently
from
January 13, 2022 14:49
0097b27 to
910979dCompareUh oh!
There was an error while loading. Please reload this page.
crazy-maxforce-pushed
the
gha-validate
branch
3 times, most recently
from
January 14, 2022 08:06
e6134bf to
5127f8fComparecrazy-maxforce-pushed
the
gha-validate
branch
7 times, most recently
from
January 18, 2022 16:18
f10b743 to
5b1ae5dComparecrazy-max
commented
Jan 18, 2022
Uh oh!
There was an error while loading. Please reload this page.
crazy-max
commented
Jan 19, 2022
MemberAuthor
crazy-maxforce-pushed
the
gha-validate
branch
7 times, most recently
from
January 27, 2022 20:11
c3efe6f to
3b6ee0dComparecrazy-maxforce-pushed
the
gha-validate
branch
2 times, most recently
from
January 28, 2022 17:53
d757a2c to
554489bCompareSigned-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> switch to cli-docs-tool and validate yamldocs Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
thaJeztah
commented
Feb 25, 2022
Member
circle-ci failure is expected (as it's removed in this PR); we could've keep it in this one, and remove after, but probably not worth the hassle |
thaJeztah
commented
Feb 25, 2022
Member
okay... here we go! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #3365
Switch to GitHub Actions for validate target:
Bake targets have also been added for each of them so we only need to set targets to the current matrix in the validate GHA workflow.
CircleCI is now removed. In a follow-up we could fix:
cli/.github/workflows/test.yml
Line 45 in 4db5a4f
cli/.github/workflows/e2e.yml
Lines 27 to 28 in 4db5a4f
Open questions:
Dockerfile.devone.GO_VERSIONbut this would enforce buildx bake usage.