Uh oh!
There was an error while loading. Please reload this page.
update docs, and remove some unused code related to "compose on kubernetes" deprecation - #3440
Merged
Merged
Conversation
thaJeztah
commented
Feb 24, 2022
Member
- Follow up to Drop support for (archived) Compose-on-Kubernetes #3139
- Addresses Drop Kubernetes support (compose-on-kubernetes is now unmaintained & archived) #2967
thaJeztah
commented
Feb 24, 2022
Comment on lines
64
to
70
| * mode (`--filter mode=replicated`, or `--filter mode=global`) | ||
| * Swarm: not supported | ||
| * Kubernetes: supported | ||
| * name (`--filter name=myapp_web`) | ||
| * Swarm: supported | ||
| * Kubernetes: supported | ||
| * node (`--filter node=mynode`) | ||
| * Swarm: not supported | ||
| * Kubernetes: supported | ||
| * service (`--filter service=web`) | ||
| * Swarm: not supported |
MemberAuthor
There was a problem hiding this comment.
Some follow-up needed after this; need to check if these options are indeed no longer supported (as they're marked as "not supported" by swarm)
thaJeztah
commented
Feb 24, 2022
| "Description": "Local Docker Engine + Azure AKS endpoint", | ||
| "StackOrchestrator": "kubernetes" | ||
| "Description": "Local Docker Engine", | ||
| "StackOrchestrator": "swarm" |
MemberAuthor
There was a problem hiding this comment.
Need to check how this is used, but possibly we could/should reset this field and hide it
Codecov Report
@@ Coverage Diff @@## master #3440 +/- ##
==========================================
- Coverage 58.29% 58.28% -0.01%
==========================================
Files 287 285 -2 Lines 24142 24134 -8 ==========================================
- Hits 14073 14067 -6 + Misses 9210 9207 -3 - Partials 859 860 +1 |
thaJeztah
commented
Feb 24, 2022
MemberAuthor
Hm... looks like this one has become flaky indeed; I opened a ticket for tracking: #3441 |
thaJeztah
commented
Feb 24, 2022
MemberAuthor
oh; let me make one more change in the first commit |
Removes the --kubeconfig flag, and the corresponding ExportOptions.Kubeconfig, as well as special handling for kubeconfig export, as it's no longer used. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was now an alias for getStackFilter, so no longer needed Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Removes the flags that have been deprecated or removed; - --default-stack-orchestrator - --kubernetes - --kubeconfig - --namespace - --orchestrator Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Remove mentions of which options are supported by Kubernetes. Note that there's some filters remaining that were marked as "not supported by swarm": those filters need to be checked if this is accurate (and if so, those filters must be removed). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Explicitly mention flags and environment variables that were removed, to make the deprecation more discoverable. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
drop_kube_follow_up
branch
from
February 24, 2022 11:28
f03fb19 to
b7d0f5cComparethaJeztah
commented
Feb 24, 2022
MemberAuthor
ok 👍 updated |
thaJeztah
commented
Feb 24, 2022
MemberAuthor
oh, of course, found one more thing; there's |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ndeloof
approved these changes
Feb 24, 2022
thaJeztah
commented
Feb 24, 2022
MemberAuthor
Thanks for reviewing; let me get this one in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.