Uh oh!
There was an error while loading. Please reload this page.
update/remove various tests and options related to kubernetes support - #3442
Merged
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Remove various tests and utilities related to testing kubernetes support Also removing the Kubernetes and DefaultStackOrchestrator from CreateOptions and UpdateOptions, instead updating the flags to not be bound to a variable. This might break some consumers of those options, but given that they've become non-functional, that's probably ok (otherwise they may ignore the deprecation warning and end up with non-functional code). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Feb 24, 2022
MemberAuthor
Sigh.. |
thaJeztah
commented
Feb 24, 2022
MemberAuthor
It really exists: https://github.com/creack/pty/blob/v1.1.11/go.mod |
thaJeztah
commented
Feb 24, 2022
MemberAuthor
Sight... and now its failing on another dependency |
ndeloof
approved these changes
Feb 25, 2022
thaJeztah
commented
Feb 25, 2022
MemberAuthor
Thanks for reviewing; let's bring this one in as well 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove unused KubernetesEnabled() test-utility
update/remove various tests and options related to kubernetes support
Remove various tests and utilities related to testing kubernetes support
Also removing the
KubernetesandDefaultStackOrchestratorfromCreateOptionsand
UpdateOptions, instead updating the flags to not be bound to a variable.This might break some consumers of those options, but given that they've become
non-functional, that's probably ok (otherwise they may ignore the deprecation
warning and end up with non-functional code).
cli/context: update package documentation