Uh oh!
There was an error while loading. Please reload this page.
improve cp documentation with some illustration examples - #3463
Conversation
codecov-commenter
commented
Mar 9, 2022
Codecov Report
@@ Coverage Diff @@## master #3463 +/- ##
=======================================
Coverage 58.99% 58.99% =======================================
Files 284 284 Lines 23848 23848 =======================================
Hits 14068 14068 Misses 8920 8920 Partials 860 860 |
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Left one comment to be fixed (and some nits while at it 😅)
| $ docker cp CONTAINER:/var/logs/app.log - | tar x -O | grep "ERROR" | ||
| ``` | ||
| ## Corner cases |
There was a problem hiding this comment.
Can you change this to a H3? The yamldocs we generate for docs.docker.com collect everything under the H2 Description and H2 Examples sections. Putting this as a H2 causes it to be skipped (but it will be included if it's a H3 within the "examples" section
| ## Corner cases | |
| ###Corner cases |
| Copy a local file into container | ||
| ```console |
There was a problem hiding this comment.
While you're fixing the H2 -> H3, could you also put a blank line between the text and the "code" block? It's not strictly needed (we did have issues with that in the past, but I think those are solved), but it's consistent with how we use them everywhere
So;
Some text before the example code
```console
$ echo "I am the example code"
```
| Copy files from container to local path | ||
| ```console |
There was a problem hiding this comment.
Same here (and the next one below)
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
closes#3431
- What I did
Added examples on docker cp reference documentation