Uh oh!
There was an error while loading. Please reload this page.
cli/command: remove unused args from ResolveDefaultContext() (step 2) - #3510
Draft
thaJeztah wants to merge 2 commits into
Draft
cli/command: remove unused args from ResolveDefaultContext() (step 2)#3510thaJeztah wants to merge 2 commits into
thaJeztah wants to merge 2 commits into
Conversation
thaJeztahforce-pushed
the
context_cleanup_part1
branch
from
March 30, 2022 16:28
298b953 to
7770910CompareCodecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
thaJeztah
commented
Mar 30, 2022
MemberAuthor
thaJeztah
commented
Apr 6, 2022
MemberAuthor
ndeloof
approved these changes
Apr 8, 2022
thaJeztah added a commit
to thaJeztah/buildx
that referenced
this pull request
Apr 8, 2022
just double-checking if docker/cli#3510 doesn't break anything. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Apr 8, 2022
| // EndpointDefaultResolver is implemented by any EndpointMeta object | ||
| // which wants to be able to populate the store with whatever their default is. | ||
| type EndpointDefaultResolver interface { |
MemberAuthor
There was a problem hiding this comment.
Looks like this is used in buildx (see docker/buildx#1054); let me check how/why and if it's strictly needed
+ xx-go build -ldflags '-X github.com/docker/buildx/version.Version=9e61f69 -X github.com/docker/buildx/version.Revision=9e61f69a5b83c3d6ee5545e488d5ad430c894276 -X github.com/docker/buildx/version.Package=github.com/docker/buildx -w -s' -o /usr/bin/buildx ./cmd/buildx
# github.com/docker/buildx/driver/kubernetes/context
driver/kubernetes/context/load.go:31:7: undefined: command.EndpointDefaultResolver
thaJeztah
commented
Apr 8, 2022
MemberAuthor
let me move this temporarily back to draft, while we can discuss what to do with these options. |
thaJeztah
marked this pull request as draft
April 8, 2022 14:52
thaJeztahforce-pushed
the
context_cleanup_part1
branch
from
July 21, 2022 16:12
c735e08 to
13edf41ComparethaJeztahforce-pushed
the
context_cleanup_part1
branch
from
July 29, 2022 07:49
13edf41 to
624d62bComparethaJeztahforce-pushed
the
context_cleanup_part1
branch
from
April 27, 2023 00:38
624d62b to
6ea9cbaComparethaJeztahforce-pushed
the
context_cleanup_part1
branch
from
May 5, 2023 23:34
6ea9cba to
d358867Comparethis was added as part of 520be05, but is not used anywhere, so we may as well simplify things a bit. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
context_cleanup_part1
branch
from
November 20, 2023 11:08
d358867 to
13bccd3Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)