Skip to content

[20.10 backport] update go to 1.17 - #3556

Merged
thaJeztah merged 3 commits into
docker:20.10from
thaJeztah:20.10_update_go_1.17
Apr 19, 2022
Merged

[20.10 backport] update go to 1.17#3556
thaJeztah merged 3 commits into
docker:20.10from
thaJeztah:20.10_update_go_1.17

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Apr 13, 2022•
edited
Loading

Copy link
Copy Markdown
Member

@thaJeztahthaJeztah added this to the 20.10.15 milestone Apr 13, 2022
@thaJeztah

thaJeztah commented Apr 13, 2022

Copy link
Copy Markdown
MemberAuthor

Ah, right, I was afraid that could be needed; likely need to run gofmt with Go 1.17 to keep the linters happy;

cli/connhelper/commandconn/session_unix.go:1: File is not `goimports`-ed (goimports)
// +build !windows
cli/connhelper/commandconn/commandconn_unix_test.go:1: File is not `goimports`-ed (goimports)
// +build !windows
cli/config/configfile/file_unix.go:1: File is not `goimports`-ed (goimports)
// +build !windows

@codecov-commenter

codecov-commenter commented Apr 14, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3556 (80f673b) into 20.10 (994ed40) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## 20.10 #3556 +/- ##
=======================================
Coverage 58.57% 58.57% =======================================
Files 299 299 Lines 21457 21457 =======================================
Hits 12569 12569 Misses 7970 7970 Partials 918 918

tonistiigiand others added 3 commits April 14, 2022 16:35
@tonistiigi@thaJeztah
update go to 1.17.8
30277a8
Removes the platform based switch between different versions.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 6119e4b)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
[20.10] update remaining files to go1.17.8
3d4cc8e
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
gofmt with go1.17
80f673b
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit a0f0578)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the 20.10_update_go_1.17 branch from f13df67 to 80f673bCompareApril 14, 2022 14:41
@thaJeztah
thaJeztah marked this pull request as ready for review April 14, 2022 14:41
@thaJeztah

thaJeztah commented Apr 19, 2022

Copy link
Copy Markdown
MemberAuthor

thx! let me bring this one in 👍

@thaJeztah
thaJeztah merged commit c73edb3 into docker:20.10Apr 19, 2022
@thaJeztah
thaJeztah deleted the 20.10_update_go_1.17 branch April 19, 2022 15:33
@thaJeztahthaJeztah mentioned this pull request May 6, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ndeloofndeloofndeloof approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/packagingimpact/changelog

Projects

None yet

Milestone

20.10.15

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@ndeloof@tonistiigi