Skip to content

introduce context show command - #3567

Merged
thaJeztah merged 1 commit into
docker:masterfrom
ndeloof:context_show
Apr 29, 2022
Merged

introduce context show command#3567
thaJeztah merged 1 commit into
docker:masterfrom
ndeloof:context_show

Conversation

@ndeloof

@ndeloofndeloof commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

closes#3425

- What I did
introduce context show command, aligned with same command introduce in compose-cli

- How I did it
new cobra command, dump current context name after checking it exists

- How to verify it
docker context show

- Description for the changelog
introduce docker context show command

- A picture of a cute animal (not mandatory but encouraged)
image

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Now that we have the docker context show command, perhaps we should

Comment threadcli/command/context/show.go
Comment threadcli/command/context/show.go Outdated
Comment threadcli/command/context/show.go Outdated
Comment threadcli/command/context/show_test.go Outdated
@codecov-commenter

codecov-commenter commented Apr 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3567 (c6b1518) into master (0b78efe) will decrease coverage by 0.01%.
The diff coverage is 27.77%.

@@ Coverage Diff @@## master #3567 +/- ##
==========================================
- Coverage 58.99% 58.98% -0.02% 
==========================================
Files 282 285 +3 Lines 23813 23834 +21 ==========================================
+ Hits 14049 14058 +9 - Misses 8908 8920 +12 
Partials 856 856 

@ndeloof
ndeloofforce-pushed the context_show branch 2 times, most recently from c6b1518 to e7fe22fCompareApril 25, 2022 12:31
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
thaJeztah merged commit e0fba5e into docker:masterApr 29, 2022
@thaJeztahthaJeztah added this to the 22.04.0 milestone Apr 29, 2022
matt9ucci added a commit to matt9ucci/DockerCompletion that referenced this pull request Feb 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command: docker context show does not exist for Linux client

4 participants

@ndeloof@codecov-commenter@rumpl@thaJeztah