Uh oh!
There was an error while loading. Please reload this page.
Move notes about required buildkit - #3730
Conversation
thaJeztah
commented
Aug 16, 2022
Thank you for contributing! It appears your commit message is missing a DCO sign-off, We require all commit messages to have a There is no need to open a new pull request, but to fix this (and make CI pass), Unfortunately, it's not possible to do so through GitHub's web UI, so this needs You can find some instructions in the output of the DCO check (which can be found Steps to do so "roughly" come down to:
Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions! |
Signed-off-by: Mathieu Rollet <matletix@gmail.com>
matletix
commented
Aug 16, 2022
Thank you, should be good now :) |
codecov-commenter
commented
Aug 16, 2022
Codecov Report
@@ Coverage Diff @@## master #3730 +/- ##
=======================================
Coverage 59.15% 59.15% =======================================
Files 289 289 Lines 24674 24674 =======================================
Hits 14597 14597 Misses 9206 9206 Partials 871 871 |
- What I did
The
docker buildcommand silently ignores the--outputflag when buildkit is not used (see #2680 and #2736). It would help to make it clear from the begining of the documentation that this feature requires buildkit.- How I did it
I just moved the note specifying the need for buildkit from the end to the begining of the related section in the documentation. I also did the same for the section about external cache sources.
- How to verify it
Check the diff
- Description for the changelog
Minor update to the CLI
docker builddocumentation