Skip to content

replace pkg/system Sequential funcs with moby/sys/sequential - #3755

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:sequential
Aug 29, 2022
Merged

replace pkg/system Sequential funcs with moby/sys/sequential#3755
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:sequential

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Migrating these functions to allow them being shared between moby, docker/cli,
and containerd, and to allow using them without importing all of sys / system,
which (in containerd) also depends on hcsshim and more.

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztahthaJeztah changed the title replace pkg/system Sequential funcs with moby/sys/sequential[WIP] replace pkg/system Sequential funcs with moby/sys/sequentialAug 27, 2022
@thaJeztahthaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Aug 27, 2022
@thaJeztahthaJeztah added this to the 22.06.0 milestone Aug 27, 2022
@codecov-commenter

codecov-commenter commented Aug 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3755 (0e3d542) into master (d89b5db) will not change coverage.
The diff coverage is 80.00%.

@@ Coverage Diff @@## master #3755 +/- ##
=======================================
Coverage 59.14% 59.14% =======================================
Files 289 289 Lines 24680 24680 =======================================
Hits 14597 14597 Misses 9212 9212 Partials 871 871 

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

For reviewers looking at the "+ LOC";

Screenshot 2022-08-27 at 15 42 40

  • most of the added lines from the new module is because it'll vendor another copy of the Apache LICENSE
  • this should all be temporary; once other dependencies have migrated to this new package, the extra copy of these functions should go away

Migrating these functions to allow them being shared between moby, docker/cli,
and containerd, and to allow using them without importing all of sys / system,
which (in containerd) also depends on hcsshim and more.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah changed the title [WIP] replace pkg/system Sequential funcs with moby/sys/sequentialreplace pkg/system Sequential funcs with moby/sys/sequentialAug 29, 2022

@sam-thibaultsam-thibault left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Thx! Bringing this one in 👍

@thaJeztah
thaJeztah merged commit b22afea into docker:masterAug 29, 2022
@thaJeztah
thaJeztah deleted the sequential branch August 29, 2022 14:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@vvoland@sam-thibault