Uh oh!
There was an error while loading. Please reload this page.
opts: remove unused RuntimeOpt - #3769
Merged
Merged
Conversation
This type was copied from the daemone in 8b725e1, but actually unused on the CLI side, so we can remove it here. The original code is still present in the daemon at https://github.com/moby/moby/blob/7b9275c0da707b030e62c96b679a976f31f929d3/opts/runtime.go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@## master #3769 +/- ##
==========================================
+ Coverage 59.14% 59.23% +0.09%
==========================================
Files 289 288 -1 Lines 24681 24641 -40 ==========================================
Hits 14597 14597 + Misses 9213 9173 -40
Partials 871 871 |
rumpl
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This type was copied from the daemon in 8b725e1 (#82), but actually unused on the CLI side, so we can remove it here.
The original code is still present in the daemon at
https://github.com/moby/moby/blob/7b9275c0da707b030e62c96b679a976f31f929d3/opts/runtime.go
- A picture of a cute animal (not mandatory but encouraged)