Uh oh!
There was an error while loading. Please reload this page.
vendor: update github.com/moby/term to fix interrupt handling - #3849
Merged
Conversation
codecov-commenter
commented
Nov 5, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## master #3849 +/- ##
=======================================
Coverage 59.17% 59.17% =======================================
Files 288 288 Lines 24647 24647 =======================================
Hits 14586 14586 Misses 9176 9176 Partials 885 885 |
On termios platforms, interrupt signals are not generated in raw mode terminals as the ISIG setting is not enabled. Remove interrupt handler as it does nothing for raw mode and prevents other uses of INT signal with this library. This code seems to go back all the way to moby/moby#214 where signal handling was improved for monolithic docker repository. Raw mode -ISIG got reintroduced in moby/moby@3f63b878076, but the INT handler was left behind. full diff: moby/term@abb1982...c43b287 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
marked this pull request as ready for review
November 28, 2022 09:29
silvin-lubecki
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On termios platforms, interrupt signals are not generated in raw mode terminals as the ISIG setting is not enabled. Remove interrupt handler as it does nothing for raw mode and prevents other uses of INT signal with this library.
This code seems to go back all the way to moby/moby#214 where signal handling was improved for monolithic docker repository. Raw mode -ISIG got reintroduced in moby/moby@3f63b878076, but the INT handler was left behind.
full diff: moby/term@abb1982...c43b287
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)