Skip to content

rm: allow docker container remove as an alias - #3986

Merged
thaJeztah merged 1 commit into
docker:masterfrom
AkihiroSuda:docker-container-remove
Jan 30, 2023
Merged

rm: allow docker container remove as an alias#3986
thaJeztah merged 1 commit into
docker:masterfrom
AkihiroSuda:docker-container-remove

Conversation

@AkihiroSuda

Copy link
Copy Markdown
Collaborator

- What I did

Fixes#3985

- How I did it

Added docker container remove as an alias of docker container rm

- How to verify it
docker container remove foo

- Description for the changelog

rm: allow docker container remove as an alias

- A picture of a cute animal (not mandatory but encouraged)

🐧

@codecov-commenter

codecov-commenter commented Jan 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #3986 (9b54d86) into master (0288f7f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@ Coverage Diff @@## master #3986 +/- ##
=======================================
Coverage 59.20% 59.20% =======================================
Files 287 287 Lines 24697 24698 +1 =======================================
+ Hits 14621 14622 +1 
Misses 9192 9192 Partials 884 884 

Comment threadcli/command/container/rm.go
Fix issue 3985
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
AkihiroSudaforce-pushed the docker-container-remove branch from e17a3b7 to 9b54d86CompareJanuary 28, 2023 23:46
@thaJeztahthaJeztah added this to the 23.0.0 milestone Jan 30, 2023

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker container remove and docker container copy do not exist, while docker (image|volume|network) remove exist

3 participants

@AkihiroSuda@codecov-commenter@thaJeztah