Skip to content

[23.0 backport] Add bash completion for available plugins - #4092

Merged
thaJeztah merged 1 commit into
docker:23.0from
crazy-max:23.0_backport_buildx-completion
Mar 22, 2023
Merged

[23.0 backport] Add bash completion for available plugins#4092
thaJeztah merged 1 commit into
docker:23.0from
crazy-max:23.0_backport_buildx-completion

Conversation

@crazy-max

@crazy-maxcrazy-max commented Mar 12, 2023

Copy link
Copy Markdown
Member

@crazy-max
crazy-max requested a review from albers as a code ownerMarch 12, 2023 17:33
@codecov-commenter

codecov-commenter commented Mar 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4092 (ac70ebc) into 23.0 (288b6c7) will not change coverage.
The diff coverage is n/a.

❗ Current head ac70ebc differs from pull request most recent head d074538. Consider uploading reports for the commit d074538 to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@## 23.0 #4092 +/- ##
=======================================
Coverage 59.14% 59.14% =======================================
Files 287 287 Lines 24738 24738 =======================================
Hits 14631 14631 Misses 9221 9221 Partials 886 886 

@crazy-max
crazy-max marked this pull request as draft March 13, 2023 15:43
@crazy-maxcrazy-max changed the title [23.0 backport] Add bash completion for docker-buildx plugin[23.0 backport] Add bash completion for available pluginsMar 13, 2023
@crazy-max
crazy-maxforce-pushed the 23.0_backport_buildx-completion branch 2 times, most recently from 37a67a5 to ac70ebcCompareMarch 14, 2023 21:58
Signed-off-by: CrazyMax <github@crazymax.dev>
(cherry picked from commit aa0aa4a)
@crazy-max
crazy-maxforce-pushed the 23.0_backport_buildx-completion branch from ac70ebc to d074538CompareMarch 17, 2023 14:06
@crazy-max
crazy-max marked this pull request as ready for review March 21, 2023 12:06
@thaJeztahthaJeztah added this to the 23.0.2 milestone Mar 21, 2023

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albersalbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah merged commit 6a8406e into docker:23.0Mar 22, 2023
@crazy-max
crazy-max deleted the 23.0_backport_buildx-completion branch March 22, 2023 19:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@crazy-max@codecov-commenter@thaJeztah@albers@neersighted