update golangci-lint to v1.52.2

[thaJeztah]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[codecov-commenter]

Codecov Report

Merging #4134 (d490397) into master (fc6703b) will decrease coverage by 0.02%.
The diff coverage is 61.11%.

❗ Current head d490397 differs from pull request most recent head e40044c. Consider uploading reports for the commit e40044c to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #4134 +/- ##
==========================================
- Coverage 59.16% 59.14% -0.02% 
==========================================
Files 287 287 Lines 24716 24713 -3 ==========================================
- Hits 14623 14617 -6 - Misses 9209 9213 +4 + Partials 884 883 -1 

[thaJeztah]

Looks like these "fakes" don't need all these "unimplemented" methods; instead of changing all the unused arguments, we may be able to remove the stubs and just embed the interface

[thaJeztah]

Not sure what went wrong here; this part looks suspicious (but maybe it's part of the test 🤔);

2023-03-30T15:25:53.7043027Z Invalid Plugins:
2023-03-30T15:25:53.7043595Z badmeta invalid metadata: invalid character 'i' looking for beginning of object key string

Details

2023-03-30T15:25:53.6911048Z === FAIL: e2e/cli-plugins TestBadHelp (0.11s)
2023-03-30T15:25:53.6911359Z run_test.go:110: assertion failed: 2023-03-30T15:25:53.6911821Z Command: docker --config /tmp/plugin-test-1119030114 badmeta -h
2023-03-30T15:25:53.6912144Z ExitCode: 0
2023-03-30T15:25:53.6923216Z Stdout: Flag shorthand -h has been deprecated, please use --help
2023-03-30T15:25:53.6923570Z 2023-03-30T15:25:53.6923798Z Usage: docker [OPTIONS] COMMAND
2023-03-30T15:25:53.6924005Z 2023-03-30T15:25:53.6924396Z A self-sufficient runtime for containers
2023-03-30T15:25:53.6924632Z 2023-03-30T15:25:53.6924815Z Common Commands:
2023-03-30T15:25:53.6925093Z run Create and run a new container from an image
2023-03-30T15:25:53.6925429Z exec Execute a command in a running container
2023-03-30T15:25:53.6925711Z ps List containers
2023-03-30T15:25:53.6925970Z build Build an image from a Dockerfile
2023-03-30T15:25:53.6926600Z pull Download an image from a registry
2023-03-30T15:25:53.6926900Z push Upload an image to a registry
2023-03-30T15:25:53.6927143Z images List images
2023-03-30T15:25:53.6927394Z login Log in to a registry
2023-03-30T15:25:53.6927656Z logout Log out from a registry
2023-03-30T15:25:53.6927918Z search Search Docker Hub for images
2023-03-30T15:25:53.6928214Z version Show the Docker version information
2023-03-30T15:25:53.6928617Z info Display system-wide information
2023-03-30T15:25:53.6929009Z 2023-03-30T15:25:53.6929217Z Management Commands:
2023-03-30T15:25:53.6929455Z builder Manage builds
2023-03-30T15:25:53.6929735Z buildx* Docker Buildx (Docker Inc., v0.10.4)
2023-03-30T15:25:53.6930004Z container Manage containers
2023-03-30T15:25:53.6930266Z context Manage contexts
2023-03-30T15:25:53.6930581Z helloworld* A basic Hello World plugin for tests (Docker Inc., testing)
2023-03-30T15:25:53.6930871Z image Manage images
2023-03-30T15:25:53.6931168Z manifest Manage Docker image manifests and manifest lists
2023-03-30T15:25:53.6931549Z nopersistentprerun*Testing without PersistentPreRun hooks (Docker Inc., testing)
2023-03-30T15:25:53.6931866Z plugin Manage plugins
2023-03-30T15:25:53.6932114Z system Manage Docker
2023-03-30T15:25:53.6932377Z trust Manage trust on Docker images
2023-03-30T15:25:53.6932643Z volume Manage volumes
2023-03-30T15:25:53.6932841Z 2023-03-30T15:25:53.6933036Z Swarm Commands:
2023-03-30T15:25:53.6933278Z config Manage Swarm configs
2023-03-30T15:25:53.6933519Z node Manage Swarm nodes
2023-03-30T15:25:53.6934038Z secret Manage Swarm secrets
2023-03-30T15:25:53.6934302Z service Manage Swarm services
2023-03-30T15:25:53.6934550Z stack Manage Swarm stacks
2023-03-30T15:25:53.6934795Z swarm Manage Swarm
2023-03-30T15:25:53.6935006Z 2023-03-30T15:25:53.6935179Z Commands:
2023-03-30T15:25:53.6935493Z attach Attach local standard input, output, and error streams to a running container
2023-03-30T15:25:53.6935965Z commit Create a new image from a container's changes
2023-03-30T15:25:53.6936298Z cp Copy files/folders between a container and the local filesystem
2023-03-30T15:25:53.6936617Z create Create a new container
2023-03-30T15:25:53.6937053Z diff Inspect changes to files or directories on a container's filesystem
2023-03-30T15:25:53.6937404Z events Get real time events from the server
2023-03-30T15:25:53.6937795Z export Export a container's filesystem as a tar archive
2023-03-30T15:25:53.6938105Z history Show the history of an image
2023-03-30T15:25:53.6938436Z import Import the contents from a tarball to create a filesystem image
2023-03-30T15:25:53.6938862Z inspect Return low-level information on Docker objects
2023-03-30T15:25:53.6939179Z kill Kill one or more running containers
2023-03-30T15:25:53.6939487Z load Load an image from a tar archive or STDIN
2023-03-30T15:25:53.6939783Z logs Fetch the logs of a container
2023-03-30T15:25:53.6940089Z pause Pause all processes within one or more containers
2023-03-30T15:25:53.6940443Z port List port mappings or a specific mapping for the container
2023-03-30T15:25:53.6940748Z rename Rename a container
2023-03-30T15:25:53.6941174Z restart Restart one or more containers
2023-03-30T15:25:53.6941461Z rm Remove one or more containers
2023-03-30T15:25:53.6941732Z rmi Remove one or more images
2023-03-30T15:25:53.6942047Z save Save one or more images to a tar archive (streamed to STDOUT by default)
2023-03-30T15:25:53.6942388Z start Start one or more stopped containers
2023-03-30T15:25:53.6942727Z stats Display a live stream of container(s) resource usage statistics
2023-03-30T15:25:53.6943056Z stop Stop one or more running containers
2023-03-30T15:25:53.6943485Z tag Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE
2023-03-30T15:25:53.7041328Z top Display the running processes of a container
2023-03-30T15:25:53.7041807Z unpause Unpause all processes within one or more containers
2023-03-30T15:25:53.7042163Z update Update configuration of one or more containers
2023-03-30T15:25:53.7042540Z wait Block until one or more containers stop, then print their exit codes
2023-03-30T15:25:53.7042821Z 2023-03-30T15:25:53.7043027Z Invalid Plugins:
2023-03-30T15:25:53.7043595Z badmeta invalid metadata: invalid character 'i' looking for beginning of object key string
2023-03-30T15:25:53.7043895Z 2023-03-30T15:25:53.7044095Z Global Options:
2023-03-30T15:25:53.7044456Z --config string Location of client config files (default
2023-03-30T15:25:53.7044763Z "/root/.docker")
2023-03-30T15:25:53.7045159Z -c, --context string Name of the context to use to connect to the
2023-03-30T15:25:53.7045486Z daemon (overrides DOCKER_HOST env var and
2023-03-30T15:25:53.7045813Z default context set with "docker context use")
2023-03-30T15:25:53.7046175Z -D, --debug Enable debug mode
2023-03-30T15:25:53.7046550Z -H, --host list Daemon socket(s) to connect to
2023-03-30T15:25:53.7046950Z -l, --log-level string Set the logging level ("debug", "info",
2023-03-30T15:25:53.7047282Z "warn", "error", "fatal") (default "info")
2023-03-30T15:25:53.7047659Z --tls Use TLS; implied by --tlsverify
2023-03-30T15:25:53.7048063Z --tlscacert string Trust certs signed only by this CA (default
2023-03-30T15:25:53.7048370Z "/root/.docker/ca.pem")
2023-03-30T15:25:53.7048764Z --tlscert string Path to TLS certificate file (default
2023-03-30T15:25:53.7049058Z "/root/.docker/cert.pem")
2023-03-30T15:25:53.7049422Z --tlskey string Path to TLS key file (default
2023-03-30T15:25:53.7049715Z "/root/.docker/key.pem")
2023-03-30T15:25:53.7050074Z --tlsverify Use TLS and verify the remote
2023-03-30T15:25:53.7050457Z -v, --version Print version information and quit
2023-03-30T15:25:53.7050708Z 2023-03-30T15:25:53.7062709Z Run 'docker COMMAND --help' for more information on a command.
2023-03-30T15:25:53.7062973Z 2023-03-30T15:25:53.7063285Z For more help on how to use Docker, head to https://docs.docker.com/go/guides/
2023-03-30T15:25:53.7063578Z 2023-03-30T15:25:53.7063753Z Stderr: 2023-03-30T15:25:53.7063966Z 2023-03-30T15:25:53.7064152Z Failures:
2023-03-30T15:25:53.7074562Z Expected stdout to contain "Flag shorthand -h has been deprecated, please use --help\n\nUsage: docker [OPTIONS] COMMAND\n\nA self-sufficient runtime for containers\n\nCommon Commands:\n run Create and run a new container from an image\n exec Execute a command in a running container\n ps List containers\n build Build an image from a Dockerfile\n pull Download an image from a registry\n push Upload an image to a registry\n images List images\n login Log in to a registry\n logout Log out from a registry\n search Search Docker Hub for images\n version Show the Docker version information\n info Display system-wide information\n\nManagement Commands:\n builder Manage builds\n buildx* Docker Buildx (Docker Inc., v0.10.4)\n container Manage containers\n context Manage contexts\n helloworld* A basic Hello World plugin for tests (Docker Inc., testing)\n image Manage images\n manifest Manage Docker image manifests and manifest lists\n network Manage networks\n nopersistentprerun*Testing without PersistentPreRun hooks (Docker Inc., testing)\n plugin Manage plugins\n system Manage Docker\n trust Manage trust on Docker images\n volume Manage volumes\n\nSwarm Commands:\n config Manage Swarm configs\n node Manage Swarm nodes\n secret Manage Swarm secrets\n service Manage Swarm services\n stack Manage Swarm stacks\n swarm Manage Swarm\n\nCommands:\n attach Attach local standard input, output, and error streams to a running container\n commit Create a new image from a container's changes\n cp Copy files/folders between a container and the local filesystem\n create Create a new container\n diff Inspect changes to files or directories on a container's filesystem\n events Get real time events from the server\n export Export a container's filesystem as a tar archive\n history Show the history of an image\n import Import the contents from a tarball to create a filesystem image\n inspect Return low-level information on Docker objects\n kill Kill one or more running containers\n load Load an image from a tar archive or STDIN\n logs Fetch the logs of a container\n pause Pause all processes within one or more containers\n port List port mappings or a specific mapping for the container\n rename Rename a container\n restart Restart one or more containers\n rm Remove one or more containers\n rmi Remove one or more images\n save Save one or more images to a tar archive (streamed to STDOUT by default)\n start Start one or more stopped containers\n stats Display a live stream of container(s) resource usage statistics\n stop Stop one or more running containers\n tag Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE\n top Display the running processes of a container\n unpause Unpause all processes within one or more containers\n update Update configuration of one or more containers\n wait Block until one or more containers stop, then print their exit codes\n\nInvalid Plugins:\n badmeta invalid metadata: invalid character 'i' looking for beginning of object key string\n\nGlobal Options:\n --config string Location of client config files (default\n \"/root/.docker\")\n -c, --context string Name of the context to use to connect to the\n daemon (overrides DOCKER_HOST env var and\n default context set with \"docker context use\")\n -D, --debug Enable debug mode\n -H, --host list Daemon socket(s) to connect to\n -l, --log-level string Set the logging level (\"debug\", \"info\",\n \"warn\", \"error\", \"fatal\") (default \"info\")\n --tls Use TLS; implied by --tlsverify\n --tlscacert string Trust certs signed only by this CA (default\n \"/root/.docker/ca.pem\")\n --tlscert string Path to TLS certificate file (default\n \"/root/.docker/cert.pem\")\n --tlskey string Path to TLS key file (default\n \"/root/.docker/key.pem\")\n --tlsverify Use TLS and verify the remote\n -v, --version Print version information and quit\n\nRun 'docker COMMAND --help' for more information on a command.\n\nFor more help on how to use Docker, head to https://docs.docker.com/go/guides/\n"

[thaJeztah]

@rumpl@vvoland@tianon ptal 🤗 🙈

[thaJeztah]

Thx! Let me bring this one in ❤️