Uh oh!
There was an error while loading. Please reload this page.
[23.0 backport] improve and load plugin command stubs when required - #4141
Merged
Conversation
thaJeztah
marked this pull request as draft
March 30, 2023 23:24
thaJeztah
commented
Mar 30, 2023
Member
Temporarily moved back to draft, as we need to investigate a possible regression; see #4142 (comment) |
We are currently loading plugin command stubs for every invocation which still has a significant performance hit. With this change we are doing this operation only if cobra completion arg request is found. - 20.10.23: `docker --version` takes ~15ms - 23.0.1: `docker --version` takes ~93ms With this change `docker --version` takes ~9ms Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit c39c711)
crazy-maxforce-pushed
the
23.0_backport_fix-perf-reg
branch
from
March 31, 2023 14:38
afec847 to
d93d785CompareCodecov Report
Additional details and impacted files@@ Coverage Diff @@## 23.0 #4141 +/- ##
==========================================
- Coverage 59.14% 59.10% -0.05%
==========================================
Files 287 287 Lines 24741 24770 +29 ==========================================
+ Hits 14634 14641 +7 - Misses 9221 9242 +21 - Partials 886 887 +1 |
crazy-max
commented
Mar 31, 2023
MemberAuthor
Removed 62f2358 from backport. PR description updated. |
crazy-max
marked this pull request as ready for review
March 31, 2023 22:04
MemberAuthor
Moved out of draft if you still wish this for next 23.0 |
laurazard
approved these changes
Apr 1, 2023
We can slightly improve plugins listing by spawning a goroutine for each iteration. Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 89583b9) # Conflicts: # vendor.mod # vendor/modules.txt
crazy-max
commented
Apr 1, 2023
MemberAuthor
@thaJeztah Cherry picked #4151 here. |
thaJeztah
approved these changes
Apr 1, 2023
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
I'll wait with merging for now (need to double-check if we want this in the first coming patch release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.