Skip to content

cli/command: remove deprecated Stream types - #4174

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove_deprecated_streams
Apr 26, 2023
Merged

cli/command: remove deprecated Stream types#4174
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove_deprecated_streams

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

These were deprecated in eb0ba4f (#1633), which was part of docker 19.03, so users should have had a chance to migrate.

This removes InStream, OutStream, NewInStream and NewOutStream

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztahthaJeztah added this to the 24.0.0 milestone Apr 9, 2023
@codecov-commenter

codecov-commenter commented Apr 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4174 (c180202) into master (26a7357) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@ Coverage Diff @@## master #4174 +/- ##
=======================================
Coverage 58.86% 58.87% =======================================
Files 572 570 -2 Lines 49572 49564 -8 =======================================
Hits 29182 29182 + Misses 18624 18616 -8 
Partials 1766 1766 

These were deprecated in eb0ba4f, which
was part of docker 19.03, so users should have had a chance to migrate.
This removes InStream, OutStream, NewInStream and NewOutStream
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the remove_deprecated_streams branch from b5c2fc6 to c180202CompareApril 25, 2023 09:08
@thaJeztah
thaJeztah marked this pull request as ready for review April 25, 2023 09:10
@thaJeztah
thaJeztah merged commit 019657a into docker:masterApr 26, 2023
@thaJeztah
thaJeztah deleted the remove_deprecated_streams branch April 26, 2023 11:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/deprecationkind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@vvoland@sam-thibault