Uh oh!
There was an error while loading. Please reload this page.
volumes: prune: add --all / -a option - #4218
Merged
Merged
Conversation
thaJeztahforce-pushed
the
volumes_prune_all
branch
from
April 20, 2023 12:59
6860ee8 to
66c38e7ComparethaJeztah
marked this pull request as ready for review
April 20, 2023 13:00
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## master #4218 +/- ##
=======================================
Coverage 58.86% 58.86% =======================================
Files 572 572 Lines 49544 49572 +28 =======================================
+ Hits 29162 29182 +20 - Misses 18616 18624 +8
Partials 1766 1766 |
thaJeztah
commented
Apr 20, 2023
MemberAuthor
/cc @cpuguy83@akerouanton@felipecruz91 ptal |
thaJeztah
commented
Apr 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
thaJeztahforce-pushed
the
volumes_prune_all
branch
2 times, most recently
from
April 20, 2023 13:14
01f2f71 to
bc52fb2CompareUh oh!
There was an error while loading. Please reload this page.
tianon
reviewed
Apr 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
volumes_prune_all
branch
from
April 20, 2023 21:32
bc52fb2 to
0dec5d2ComparethaJeztah
commented
Apr 20, 2023
MemberAuthor
updated; PTAL |
thaJeztah
commented
Apr 20, 2023
MemberAuthor
I'm wondering if we should backport this one for 23.0. It's a new flag, but I think we really just forgot to add this flag to the CLI (and it was the original intent to add it, we just overlooked it). Basically, I want to avoid users having to get used to |
tianon
approved these changes
Apr 20, 2023
tianon
commented
Apr 20, 2023
Contributor
A backport to 23.x sounds sane to me 😅 |
cpuguy83
approved these changes
Apr 20, 2023
cpuguy83
commented
Apr 20, 2023
Collaborator
Backport also SGTM. |
edmorley added a commit
to edmorley/docker-cli
that referenced
this pull request
Aug 12, 2023
In previous versions of the Docker API, `system prune --volumes` and `volume prune` would remove all dangling volumes. With API v1.42, this was changed so that only anonymous volumes would be removed unless the all filter was specified. Some of the docs were updated in docker#4218, however, there were a couple of places left that didn't make the anonymous vs named volumes distinction clear. This replaces docker#4079, which was bitrotted by docker#4218. See also docker#4028. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
edmorley added a commit
to edmorley/docker-cli
that referenced
this pull request
Aug 12, 2023
In previous versions of the Docker API, `system prune --volumes` and `volume prune` would remove all dangling volumes. With API v1.42, this was changed so that only anonymous volumes would be removed unless the all filter was specified. Some of the docs were updated in docker#4218, however, there were a couple of places left that didn't make the anonymous vs named volumes distinction clear. This replaces docker#4079, which was bitrotted by docker#4218. See also docker#4028. Closesdocker#4079. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
thaJeztah pushed a commit
to thaJeztah/cli
that referenced
this pull request
Aug 25, 2023
In previous versions of the Docker API, `system prune --volumes` and `volume prune` would remove all dangling volumes. With API v1.42, this was changed so that only anonymous volumes would be removed unless the all filter was specified. Some of the docs were updated in docker#4218, however, there were a couple of places left that didn't make the anonymous vs named volumes distinction clear. This replaces docker#4079, which was bitrotted by docker#4218. See also docker#4028. Closesdocker#4079. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com> (cherry picked from commit 6e2e92d) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
matt9ucci added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)