Skip to content

cli-plugins: remove deprecated Metadata.Experimental - #4342

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove_cli_plugins_metadata_experimental
Jun 12, 2023
Merged

cli-plugins: remove deprecated Metadata.Experimental#4342
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove_cli_plugins_metadata_experimental

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

relates to:

This field was marked deprecated in 977d3ae (#2774), which is part of Docker 20.10 and up.

This patch removes the field.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This field was marked deprecated in 977d3ae,
which is part of Docker 20.10 and up.
This patch removes the field.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

@laurazardlaurazard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jun 12, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4342 (6a50c4f) into master (f26ac47) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@ Coverage Diff @@## master #4342 +/- ##
=======================================
Coverage 59.29% 59.29% =======================================
Files 288 288 Lines 24769 24769 =======================================
Hits 14688 14688 Misses 9197 9197 Partials 884 884 

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Failure on macOS should be unrelated, but looks like it may be related to the ssh changes;

--- FAIL: TestCloseWhileReading (0.00s)
commandconn_unix_test.go:211: assertion failed: expected error to contain "EOF", got "read |0: file already closed"
FAIL

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

All green now 👍

@thaJeztah
thaJeztah merged commit 8aee745 into docker:masterJun 12, 2023
@thaJeztah
thaJeztah deleted the remove_cli_plugins_metadata_experimental branch June 12, 2023 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@codecov-commenter@laurazard