Uh oh!
There was an error while loading. Please reload this page.
Add otel support - #4556
Closed
cpuguy83 wants to merge 2 commits into
Closed
Conversation
cpuguy83force-pushed
the
otel
branch
3 times, most recently
from
September 10, 2023 15:54
2f9b0db to
3bfa506CompareThis is to prepare for otel support. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83force-pushed
the
otel
branch
4 times, most recently
from
September 10, 2023 17:16
db2f196 to
7eb3218CompareSigned-off-by: Brian Goff <cpuguy83@gmail.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
thaJeztah
commented
Sep 11, 2023
Member
/cc @milas as well (just a "FYI", but perhaps there's input from your side to make this align with compose's OTEL integration) |
Comment on lines
+50
to
+53
| require ( | ||
| go.opentelemetry.io/otel v1.4.1 | ||
| go.opentelemetry.io/otel/trace v1.4.1 | ||
| ) |
Member
There was a problem hiding this comment.
These ended up in the wrong block
cpuguy83
commented
Sep 14, 2023
CollaboratorAuthor
Just a heads up, this is causing |
This was referenced Dec 6, 2023
thaJeztah
commented
Dec 6, 2023
Member
I did a rebase of this branch (and fixed some OTEL changes that were in the wrong commit 😂). Looks like OTEL itself is still causing some headaches, so I split the changes in 2 PRs; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is broken into 2 commits: