Uh oh!
There was an error while loading. Please reload this page.
e2e: update to use compose v2, and don't depend on distro-packages - #4576
Merged
Conversation
We were depending on alpine's package repository to install compose, but for debian we used compose's GitHub releases. Depending on distro packages means that we don't know when updates will happen, and versions may diverge because of that; for example, alpine 3.18 updated to compose v2; On alpine 3.17: make -f docker.Makefile build-e2e-image docker run --rm docker-cli-e2e docker-compose --version docker-compose version 1.29.2, build unknown On alpine 3.18: make -f docker.Makefile build-e2e-image docker run --rm docker-cli-e2e docker-compose --version Docker Compose version v2.17.3 This caused our e2e script to fail, as it made assumptions about the name format created by compose, which changed from underscores to hyphens in v2; Container cliendtoendsuite-engine-1 Running Error: No such object: cliendtoendsuite_engine_1 This patch: - updates the Dockerfile to install compose from the compose-bin image - adjusts the e2e script for the new naming scheme format - removes the version field from the compose-files used in e2e, as they are no longer used by compose. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
update_compose_v2
branch
from
September 26, 2023 10:21
29d047e to
9e424afCompare2 tasks
vvoland
approved these changes
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were depending on alpine's package repository to install compose, but for debian we used compose's GitHub releases. Depending on distro packages means that we don't know when updates will happen, and versions may diverge because of that; for example, alpine 3.18 updated to compose v2;
On alpine 3.17:
On alpine 3.18:
This caused our e2e script to fail, as it made assumptions about the name format created by compose, which changed from underscores to hyphens in v2;
This patch:
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)