Uh oh!
There was an error while loading. Please reload this page.
Remove 5k lines of unnecessary dependencies - #480
Merged
Conversation
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
vieux
commented
Aug 29, 2017
Contributor
|
Codecov Report
@@ Coverage Diff @@## master #480 +/- ##
=======================================
Coverage 48.62% 48.62% =======================================
Files 199 199 Lines 16396 16396 =======================================
Hits 7973 7973 Misses 8007 8007 Partials 416 416 |
tiborvass
commented
Aug 29, 2017
Collaborator
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDecodeContainerConfigVolumeswas testingrunconfig.DecodeContainerConfigindocker/docker/runconfignot this repo.Removing it allows us to remove a bunch of unused dependencies from vendor.
This is point 2 from #424 (review)
These tests will be moved to
moby/mobyin (TODO: link PR here when opened)cc @simonferquel