Uh oh!
There was an error while loading. Please reload this page.
cli/command: deprecate EventHandler and InitEventHandler - #4936
Merged
Conversation
vvoland
approved these changes
Mar 11, 2024
krissetto
approved these changes
Mar 11, 2024
| handlers map[events.Action]func(events.Message) | ||
| } | ||
| func (w *eventHandler) handle(action events.Action, h func(events.Message)) { |
Contributor
There was a problem hiding this comment.
Very minor nits here:
was the eventHandler name? Could we useehlike we do above?- For the naming i'd suggest something along the lines of
setHandler/setActionHandleretc since we don't actually do any handling in here. WDYT?
MemberAuthor
There was a problem hiding this comment.
Ah, yes, can rename the receiver. no idea where the original w came from (I just copied).
Perhaps setHandler (or addHandler maybe?) would work here. I can change that. That said, I think we need to cleanup more in this area. It's all feels a bit over-complicated (also looking at the monitorContainerEvents closure - perhaps things can be rolled up there). I didn't spend too much time yet looking at what's best there.
This code was only used as part of container.RunStats, so moving the code there instead as a non-exported type. The actual use also did not have to handle concurrency, so the mutex is removed in the new location. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
deprecate_eventhandler
branch
from
March 11, 2024 12:25
bf362a6 to
46afd26CompareCodecov Report
Additional details and impacted files@@ Coverage Diff @@## master #4936 +/- ##
==========================================
- Coverage 61.47% 61.43% -0.04%
==========================================
Files 289 289 Lines 20226 20237 +11 ==========================================
Hits 12433 12433 - Misses 6892 6903 +11
Partials 901 901 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was only used as part of container.RunStats, so moving the code there instead as a non-exported type. The actual use also did not have to handle concurrency, so the mutex is removed in the new location.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)