Uh oh!
There was an error while loading. Please reload this page.
plugin: drop explicit unlink - #4963
Merged
Merged
Conversation
krissetto
approved these changes
Mar 22, 2024
krissetto
left a comment
Contributor
There was a problem hiding this comment.
LGTM in the context of plugins at least :)
Benehiko
approved these changes
Mar 22, 2024
vvoland
reviewed
Mar 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
neersightedforce-pushed
the
plugin_comments
branch
from
March 22, 2024 15:41
1860e95 to
c1f9937Comparecodecov-commenter
commented
Mar 22, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@## master #4963 +/- ##
==========================================
- Coverage 61.79% 61.78% -0.01%
==========================================
Files 289 289 Lines 20267 20265 -2 ==========================================
- Hits 12523 12521 -2
Misses 6858 6858 Partials 886 886 |
Go's `net` package [will unlink][1] for us, as long as we used Listen & friends to create the Unix socket. Go will even skip the unlink when the socket appears to be abstract (starts with a NUL, represented by an @), though we must be cautious to only create sockets with an abstract address on platforms that actually support it -- this caused [several][2] [bugs][3] before. [1]: https://pkg.go.dev/net#UnixListener.SetUnlinkOnClose [2]: docker#4783 [3]: docker#4863 Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
neersightedforce-pushed
the
plugin_comments
branch
from
March 22, 2024 16:12
c1f9937 to
509123fComparevvoland
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go's
netpackage will unlink for us, as long as we used listen to create the Unix socket.Go will even skip the unlink when the socket appears to be abstract (start with a NUL, represented by an @), though we must be cautious to only create sockets with an abstract address on platforms that actually support it -- this caused severalbugs before.