Skip to content

[27.x] vendor: github.com/docker/docker f9522e5e96c3 (v27.1.2-dev) (removes containerd dependency) - #5333

Merged
vvoland merged 2 commits into
docker:27.xfrom
thaJeztah:27.x_bump_engine
Aug 12, 2024
Merged

[27.x] vendor: github.com/docker/docker f9522e5e96c3 (v27.1.2-dev) (removes containerd dependency)#5333
vvoland merged 2 commits into
docker:27.xfrom
thaJeztah:27.x_bump_engine

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Aug 8, 2024

Copy link
Copy Markdown
Member

vendor: github.com/docker/docker f9522e5e96c3 (v27.1.2-dev)

Removes dependency on containerd, as the userns package was migrated
to the github.com/moby/sys/userns module.

full diff: golang/sys@v0.21.0...v0.22.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 501904d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

codecov-commenter commented Aug 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.49%. Comparing base (c7f3031) to head (65dec14).
Report is 14 commits behind head on 27.x.

Additional details and impacted files
@@ Coverage Diff @@## 27.x #5333 +/- ##
=======================================
Coverage 61.49% 61.49% =======================================
Files 299 299 Lines 20867 20869 +2 =======================================
+ Hits 12832 12834 +2 
Misses 7120 7120 Partials 915 915 

Removes dependency on containerd, as the userns package was migrated
to the github.com/moby/sys/userns module.
- full diff: moby/moby@v27.1.1...f9522e5
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvolandvvoland changed the title [27.x] vendor: github.com/docker/docker f5fa0908efa4 (v27.1.2-dev) (removes containerd dependency)[27.x] vendor: github.com/docker/docker f9522e5e96c3 (v27.1.2-dev) (removes containerd dependency)Aug 12, 2024
@vvoland

Copy link
Copy Markdown
Collaborator

Updated to latest 27.x, @thaJeztah PTAL

@vvoland
vvoland marked this pull request as ready for review August 12, 2024 11:19
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Yeah, I was considering if we already needed this one; or at least; if someone would update both docker/docker and docker/cli, they would already get these updates (there's no local changes).

Either way is fine with me though 😅

@vvoland
vvoland merged commit d01f264 into docker:27.xAug 12, 2024
@thaJeztah
thaJeztah deleted the 27.x_bump_engine branch August 13, 2024 12:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah@codecov-commenter@vvoland