Skip to content

Images Tree: Change 'Used' to 'In Use' - #5474

Merged
thaJeztah merged 1 commit into
masterfrom
change_to_inuse
Sep 24, 2024
Merged

Images Tree: Change 'Used' to 'In Use'#5474
thaJeztah merged 1 commit into
masterfrom
change_to_inuse

Conversation

@cpuguy83

@cpuguy83cpuguy83 commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

I was showing off docker images --tree and it came up (@tianon) that Used is not quite the right term here.

- Description for the changelog

- containerd image store: change name of `USED` column in `docker image ls --tree` to `IN USE`.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@codecov-commenter

codecov-commenter commented Sep 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.74%. Comparing base (9d478be) to head (df52ddc).
Report is 45 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5474 +/- ##
=======================================
Coverage 59.74% 59.74% =======================================
Files 345 345 Lines 23431 23431 =======================================
Hits 13999 13999 Misses 8458 8458 Partials 974 974 

@tianon

Copy link
Copy Markdown
Contributor

picture of the "Welcome to Fabulous Goodwill Las Vegas" sign

😇

@laurazardlaurazard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this does sound better 😅 LGTM

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
thaJeztah merged commit 56d0af7 into masterSep 24, 2024
@thaJeztah
thaJeztah deleted the change_to_inuse branch September 24, 2024 08:40
@thaJeztah

Copy link
Copy Markdown
Member

OH, lol; looks like you opened this PR from a branch on this repository, not your fork

@cpuguy83

Copy link
Copy Markdown
CollaboratorAuthor

Oops , fresh checkout on a new machine. Didn't think to fix it. 🙀

@thaJeztah

Copy link
Copy Markdown
Member

No worries; no harm done ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@cpuguy83@codecov-commenter@tianon@thaJeztah@laurazard