Skip to content

update go:build tags to use go1.22 - #5608

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:go1.22_buildtags
Nov 12, 2024
Merged

update go:build tags to use go1.22#5608
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:go1.22_buildtags

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Nov 12, 2024

Copy link
Copy Markdown
Member

commit 4a7b04d configured golangci-lint to use go1.23 semantics, which enabled the copyloopvar linter.

go1.22 now creates a copy of variables when assigned in a loop; make sure we don't have files that may downgrade semantics to go1.21 in case that also means disabling that feature; https://go.dev/ref/spec#Go_1.22

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

codecov-commenter commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (917d2dc) to head (7c80e4f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5608 +/- ##
=======================================
Coverage 59.63% 59.63% =======================================
Files 346 346 Lines 29208 29208 =======================================
Hits 17417 17417 Misses 10822 10822 Partials 969 969 

commit 4a7b04d configured golangci-lint
to use go1.23 semantics, which enabled the copyloopvar linter.
go1.22 now creates a copy of variables when assigned in a loop; make sure we
don't have files that may downgrade semantics to go1.21 in case that also means
disabling that feature; https://go.dev/ref/spec#Go_1.22
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@Benehiko@laurazard