Uh oh!
There was an error while loading. Please reload this page.
[27.x backport] bump golangci-lint to v1.61.0 and cleanup config - #5613
Merged
thaJeztah merged 5 commits intoNov 14, 2024
Conversation
There's only 3 locations where it's hit, so putting #gosec ignore comments in those locations. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 020f3a7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7451339) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 745629b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## 27.x #5613 +/- ##
==========================================
- Coverage 58.65% 58.38% -0.27%
==========================================
Files 345 336 -9 Lines 29053 28782 -271 ==========================================
- Hits 17040 16805 -235 + Misses 11042 11010 -32 + Partials 971 967 -4 |
thaJeztah
commented
Nov 13, 2024
MemberAuthor
Looks like that's fixed in a6e96c7, part of #5234, but not sure if we want to backport all of that |
…govet)
cli/required.go:17:24: printf: non-constant format string in call to github.com/docker/cli/vendor/github.com/pkg/errors.Errorf (govet)
return errors.Errorf("\n" + strings.TrimRight(cmd.UsageString(), "\n"))
^
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>Also updating a linter that was deprecated; The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 9af049c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
27.x_backport_bump_golangci_lint
branch
from
November 14, 2024 08:44
20d29a4 to
8fe9372Comparelaurazard
commented
Nov 14, 2024
Member
I think it's fine as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- A picture of a cute animal (not mandatory but encouraged)