Skip to content

cli/command/container: fix missing go:build tag - #5621

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:more_go_build_tags
Nov 15, 2024
Merged

cli/command/container: fix missing go:build tag#5621
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:more_go_build_tags

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Nov 15, 2024

Copy link
Copy Markdown
Member

make shell
make -C ./internal/gocompat/
GO111MODULE=on go test -v
# github.com/docker/cli/cli/command/container
../../cli/command/container/completion.go:37:28: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
../../cli/command/container/completion.go:82:25: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
../../cli/command/container/completion.go:92:27: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
FAIL	gocompat [build failed]

- A picture of a cute animal (not mandatory but encouraged)

 make shell
make -C ./internal/gocompat/
GO111MODULE=on go test -v
# github.com/docker/cli/cli/command/container
../../cli/command/container/completion.go:37:28: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
../../cli/command/container/completion.go:82:25: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
../../cli/command/container/completion.go:92:27: implicit function instantiation requires go1.18 or later (-lang was set to go1.16; check go.mod)
FAIL	gocompat [build failed]
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 28.0.0 milestone Nov 15, 2024
@thaJeztahthaJeztah self-assigned this Nov 15, 2024
@codecov-commenter

codecov-commenter commented Nov 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.50%. Comparing base (4adbb18) to head (d1d5353).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5621 +/- ##
=======================================
Coverage 59.50% 59.50% =======================================
Files 346 346 Lines 29365 29365 =======================================
Hits 17474 17474 Misses 10916 10916 Partials 975 975 

@thaJeztah
thaJeztah merged commit 9861ce9 into docker:masterNov 15, 2024
@thaJeztah
thaJeztah deleted the more_go_build_tags branch November 15, 2024 10:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdkChanges affecting the Go SDKkind/bugfixPR's that fix bugsprocess/cherry-pickedstatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@vvoland@Benehiko