docker trust: interact with signers and keys

cli/command/trust/client_test.go

@@ -316,7 +316,39 @@ func (l LoadedNotaryRepository) ListRoles() ([]client.RoleWithSignatures, error)
  Name: data.CanonicalTargetsRole,
 	}
 
-	return []client.RoleWithSignatures{{Role: rootRole}, {Role: targetsRole}}, nil
+	aliceRole := data.Role{
+ RootRole: data.RootRole{
+ KeyIDs: []string{"A"},
+ Threshold: 1,
+ },
+ Name: data.RoleName("targets/alice"),
+	}
+
+	bobRole := data.Role{
+ RootRole: data.RootRole{
+ KeyIDs: []string{"B"},
+ Threshold: 1,
+ },
+ Name: data.RoleName("targets/bob"),
+	}
+
+	releasesRole := data.Role{
+ RootRole: data.RootRole{
+ KeyIDs: []string{"A", "B"},
+ Threshold: 1,
+ },
+ Name: data.RoleName("targets/releases"),
+	}
+	// have releases only signed off by Alice last
+	releasesSig := []data.Signature{{KeyID: "A"}}
+
+	return []client.RoleWithSignatures{
+ {Role: rootRole},
+ {Role: targetsRole},
+ {Role: aliceRole},
+ {Role: bobRole},
+ {Role: releasesRole, Signatures: releasesSig},
+	}, nil
 }
 
 func (l LoadedNotaryRepository) ListTargets(roles ...data.RoleName) ([]*client.TargetWithRole, error) {

cli/command/trust/cmd.go

@@ -18,6 +18,8 @@ func NewTrustCommand(dockerCli command.Cli) *cobra.Command {
  newViewCommand(dockerCli),
  newRevokeCommand(dockerCli),
  newSignCommand(dockerCli),
+ newTrustKeyCommand(dockerCli),
+ newTrustSignerCommand(dockerCli),
 	)
 	return cmd
 }

cli/command/trust/helpers.go

@@ -9,13 +9,15 @@ import (
 )
 
 const releasedRoleName = "Repo Admin"
+const releasesRoleTUFName = "targets/releases"
 
-// check if a role name is "released": either targets/releases or targets TUF roles
+// isReleasedTarget checks if a role name is "released":
+// either targets/releases or targets TUF roles
 func isReleasedTarget(role data.RoleName) bool {
 	return role == data.CanonicalTargetsRole || role == trust.ReleasesRole
 }
 
-// convert TUF role name to a human-understandable signer name
+// notaryRoleToSigner converts TUF role name to a human-understandable signer name
 func notaryRoleToSigner(tufRole data.RoleName) string {
 	// don't show a signer for "targets" or "targets/releases"
 	if isReleasedTarget(data.RoleName(tufRole.String())) {
@@ -24,10 +26,22 @@ func notaryRoleToSigner(tufRole data.RoleName) string {
 	return strings.TrimPrefix(tufRole.String(), "targets/")
 }
 
+// clearChangelist clears the notary staging changelist.
 func clearChangeList(notaryRepo client.Repository) error {
 	cl, err := notaryRepo.GetChangelist()
 	if err != nil {
  return err
 	}
 	return cl.Clear("")
 }
+
+// getOrGenerateRootKeyAndInitRepo initializes the notary repository
+// with a remotely managed snapshot key. The initialization will use
+// an existing root key if one is found, else a new one will be generated.
+func getOrGenerateRootKeyAndInitRepo(notaryRepo client.Repository) error {
+	rootKey, err := getOrGenerateNotaryKey(notaryRepo, data.CanonicalRootRole)
+	if err != nil {
+ return err
+	}
+	return notaryRepo.Initialize([]string{rootKey.ID()}, data.CanonicalSnapshotRole)
+}

cli/command/trust/helpers_test.go

@@ -0,0 +1,25 @@
+package trust
+
+import (
+	"io/ioutil"
+	"os"
+	"testing"
+
+	"github.com/docker/notary/client"
+	"github.com/docker/notary/passphrase"
+	"github.com/docker/notary/trustpinning"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetOrGenerateNotaryKeyAndInitRepo(t *testing.T) {
+	tmpDir, err := ioutil.TempDir("", "notary-test-")
+	assert.NoError(t, err)
+	defer os.RemoveAll(tmpDir)
+
+	notaryRepo, err := client.NewFileCachedRepository(tmpDir, "gun", "https://localhost", nil, passphrase.ConstantRetriever(passwd), trustpinning.TrustPinConfig{})
+	assert.NoError(t, err)
+
+	err = getOrGenerateRootKeyAndInitRepo(notaryRepo)
+	assert.EqualError(t, err, "client is offline")
+}

cli/command/trust/key.go

@@ -0,0 +1,22 @@
+package trust
+
+import (
+	"github.com/docker/cli/cli"
+	"github.com/docker/cli/cli/command"
+	"github.com/spf13/cobra"
+)
+
+// newTrustKeyCommand returns a cobra command for `trust key` subcommands
+func newTrustKeyCommand(dockerCli command.Streams) *cobra.Command {
+	cmd := &cobra.Command{
+ Use: "key",
+ Short: "Manage keys for signing Docker images (experimental)",
+ Args: cli.NoArgs,
+ RunE: command.ShowHelp(dockerCli.Err()),
+	}
+	cmd.AddCommand(
+ newKeyGenerateCommand(dockerCli),
+ newKeyLoadCommand(dockerCli),
+	)
+	return cmd
+}

cli/command/trust/key_generate.go

@@ -0,0 +1,134 @@
+package trust
+
+import (
+	"encoding/pem"
+	"fmt"
+	"io/ioutil"
+	"os"
+	"path/filepath"
+	"regexp"
+	"strings"
+
+	"github.com/docker/cli/cli"
+	"github.com/docker/cli/cli/command"
+	"github.com/docker/cli/cli/trust"
+	"github.com/docker/notary"
+	"github.com/docker/notary/trustmanager"
+	"github.com/docker/notary/tuf/data"
+	tufutils "github.com/docker/notary/tuf/utils"
+	"github.com/pkg/errors"
+	"github.com/spf13/cobra"
+)
+
+type keyGenerateOptions struct {
+	name string
+	directory string
+}
+
+func newKeyGenerateCommand(dockerCli command.Streams) *cobra.Command {
+	options := keyGenerateOptions{}
+	cmd := &cobra.Command{
+ Use: "generate NAME",
+ Short: "Generate and load a signing key-pair",
+ Args: cli.ExactArgs(1),
+ RunE: func(cmd *cobra.Command, args []string) error {
+ options.name = args[0]
+ return setupPassphraseAndGenerateKeys(dockerCli, options)
+ },
+	}
+	flags := cmd.Flags()
+	flags.StringVar(&options.directory, "dir", "", "Directory to generate key in, defaults to current directory")
+	return cmd
+}
+
+// key names can use lowercase alphanumeric + _ + - characters
+var validKeyName = regexp.MustCompile(`^[a-z0-9][a-z0-9\_\-]*$`).MatchString
+
+// validate that all of the key names are unique and are alphanumeric + _ + -
+// and that we do not already have public key files in the target dir on disk
+func validateKeyArgs(keyName string, targetDir string) error {
+	if !validKeyName(keyName) {
+ return fmt.Errorf("key name \"%s\" must start with lowercase alphanumeric characters and can include \"-\" or \"_\" after the first character", keyName)
+	}
+
+	pubKeyFileName := keyName + ".pub"
+	if _, err := os.Stat(targetDir); err != nil {
+ return fmt.Errorf("public key path does not exist: \"%s\"", targetDir)
+	}
+	targetPath := filepath.Join(targetDir, pubKeyFileName)
+	if _, err := os.Stat(targetPath); err == nil {
+ return fmt.Errorf("public key file already exists: \"%s\"", targetPath)
+	}
+	return nil
+}
+
+func setupPassphraseAndGenerateKeys(streams command.Streams, opts keyGenerateOptions) error {
+	targetDir := opts.directory
+	if targetDir == "" {
+ cwd, err := os.Getwd()
+ if err != nil {
+ return err
+ }
+ targetDir = cwd
+	}
+	return validateAndGenerateKey(streams, opts.name, targetDir)
+}
+
+func validateAndGenerateKey(streams command.Streams, keyName string, workingDir string) error {
+	freshPassRetGetter := func() notary.PassRetriever { return trust.GetPassphraseRetriever(streams.In(), streams.Out()) }
+	if err := validateKeyArgs(keyName, workingDir); err != nil {
+ return err
+	}
+	fmt.Fprintf(streams.Out(), "Generating key for %s...\n", keyName)
+	// Automatically load the private key to local storage for use
+	privKeyFileStore, err := trustmanager.NewKeyFileStore(trust.GetTrustDirectory(), freshPassRetGetter())
+	if err != nil {
+ return err
+	}
+
+	pubPEM, err := generateKeyAndOutputPubPEM(keyName, privKeyFileStore)
+	if err != nil {
+ fmt.Fprintf(streams.Out(), err.Error())
+ return errors.Wrapf(err, "failed to generate key for %s", keyName)
+	}
+
+	// Output the public key to a file in the CWD or specified dir
+	writtenPubFile, err := writePubKeyPEMToDir(pubPEM, keyName, workingDir)
+	if err != nil {
+ return err
+	}
+	fmt.Fprintf(streams.Out(), "Successfully generated and loaded private key. Corresponding public key available: %s\n", writtenPubFile)
+
+	return nil
+}
+
+func generateKeyAndOutputPubPEM(keyName string, privKeyStore trustmanager.KeyStore) (pem.Block, error) {
+	privKey, err := tufutils.GenerateKey(data.ECDSAKey)
+	if err != nil {
+ return pem.Block{}, err
+	}
+
+	privKeyStore.AddKey(trustmanager.KeyInfo{Role: data.RoleName(keyName)}, privKey)
+	if err != nil {
+ return pem.Block{}, err
+	}
+
+	pubKey := data.PublicKeyFromPrivate(privKey)
+	return pem.Block{
+ Type: "PUBLIC KEY",
+ Headers: map[string]string{
+ "role": keyName,
+ },
+ Bytes: pubKey.Public(),
+	}, nil
+}
+
+func writePubKeyPEMToDir(pubPEM pem.Block, keyName, workingDir string) (string, error) {
+	// Output the public key to a file in the CWD or specified dir
+	pubFileName := strings.Join([]string{keyName, "pub"}, ".")
+	pubFilePath := filepath.Join(workingDir, pubFileName)
+	if err := ioutil.WriteFile(pubFilePath, pem.EncodeToMemory(&pubPEM), notary.PrivNoExecPerms); err != nil {
+ return "", errors.Wrapf(err, "failed to write public key to %s", pubFilePath)
+	}
+	return pubFilePath, nil
+}