Skip to content

cli/trust: GetNotaryRepository: remove uses of RepositoryInfo.Class - #5660

Merged
laurazard merged 1 commit into
docker:masterfrom
thaJeztah:remove_repoinfo_class
Dec 2, 2024
Merged

cli/trust: GetNotaryRepository: remove uses of RepositoryInfo.Class#5660
laurazard merged 1 commit into
docker:masterfrom
thaJeztah:remove_repoinfo_class

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

The Class field was added because Docker Hub registry required a special scope to be set for pulling plugins;

HTTP/1.1 401 Unauthorized
...
Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io",scope="repository(plugin):vieux/sshfs:pull",error="insufficient_scope"

This is no longer a requirement, and the field is no longer set.

updates 0ba820e

- A picture of a cute animal (not mandatory but encouraged)

The Class field was added because Docker Hub registry required a special
scope to be set for pulling plugins;
HTTP/1.1 401 Unauthorized
...
Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io",scope="repository(plugin):vieux/sshfs:pull",error="insufficient_scope"
This is no longer a requirement, and the field is no longer set.
updates 0ba820e
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter

codecov-commenter commented Nov 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.53%. Comparing base (61b02e6) to head (ed9fcf3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5660 +/- ##
=======================================
Coverage 59.53% 59.53% =======================================
Files 346 346 Lines 29357 29356 -1 =======================================
Hits 17477 17477 + Misses 10910 10909 -1 
Partials 970 970 

@laurazard
laurazard merged commit 5afa739 into docker:masterDec 2, 2024
@thaJeztah
thaJeztah deleted the remove_repoinfo_class branch December 2, 2024 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@vvoland@laurazard