Uh oh!
There was an error while loading. Please reload this page.
cli/command/container: ensure channel is allocated - #577
Merged
Conversation
Signed-off-by: Stephen J Day <stephen.day@docker.com>
tonistiigi
commented
Sep 30, 2017
Member
LGTM |
codecov-io
commented
Sep 30, 2017
Codecov Report
@@ Coverage Diff @@## master #577 +/- ##
==========================================
- Coverage 49.38% 49.38% -0.01%
==========================================
Files 208 208 Lines 17175 17178 +3 ==========================================
+ Hits 8482 8483 +1 - Misses 8260 8262 +2
Partials 433 433 |
andrewhsu
commented
Sep 30, 2017
Contributor
Related to changes introduced in #570: |
andrewhsu
approved these changes
Sep 30, 2017
andrewhsu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
this PR addresses the integration-cli test failures we were seeing in docker-ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day stephen.day@docker.com