Skip to content

docs/generate: remove uses of pkg/errors - #5784

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:docs_gen_no_pkg_errors
Mar 19, 2025
Merged

docs/generate: remove uses of pkg/errors#5784
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:docs_gen_no_pkg_errors

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

While there may be reasons to keep pkg/errors in production code, we don't need them for these tests.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter

codecov-commenter commented Feb 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (ecfdf74) to head (2f79598).
Report is 6 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5784 +/- ##
=======================================
Coverage 59.28% 59.28% =======================================
Files 358 358 Lines 29830 29830 =======================================
Hits 17685 17685 Misses 11173 11173 Partials 972 972 
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thaJeztah
thaJeztahforce-pushed the docs_gen_no_pkg_errors branch from 053cb74 to 101862cCompareFebruary 1, 2025 18:54
@thaJeztahthaJeztah changed the title docs/generate: remove uses of pkg/errors in testsdocs/generate: remove uses of pkg/errorsFeb 1, 2025
@thaJeztah
thaJeztahforce-pushed the docs_gen_no_pkg_errors branch from 101862c to 8cc7e55CompareFebruary 3, 2025 10:08
@thaJeztahthaJeztah self-assigned this Feb 3, 2025
While there may be reasons to keep pkg/errors in production code,
we don't need them for this generator code.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the docs_gen_no_pkg_errors branch from 8cc7e55 to 2f79598CompareMarch 19, 2025 09:49
@thaJeztah
thaJeztah marked this pull request as ready for review March 19, 2025 09:49
@thaJeztah
thaJeztah requested a review from a team as a code ownerMarch 19, 2025 09:49
@thaJeztahthaJeztah added this to the 28.0.2 milestone Mar 19, 2025
@thaJeztah
thaJeztah merged commit 63f5930 into docker:masterMar 19, 2025
@thaJeztah
thaJeztah deleted the docs_gen_no_pkg_errors branch March 19, 2025 12:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/packagingkind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@Benehiko@vvoland