Skip to content

cli/registry/client: remove dependency on trust / notary - #5880

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:registry_decouple_trust
Mar 3, 2025
Merged

cli/registry/client: remove dependency on trust / notary#5880
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:registry_decouple_trust

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

The client was only using the Actions consts, but the trust package also has a dependency on notary. Remove the import to prevent Notary becoming a dependency for uses of the cli code.

- A picture of a cute animal (not mandatory but encouraged)

The client was only using the Actions consts, but the trust package
also has a dependency on notary. Remove the import to prevent Notary
becoming a dependency for uses of the cli code.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 28.0.2 milestone Mar 3, 2025
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Looks like I forgot to include this one in #5878 - this one should also be trivial; the predefined vars are nice, but don't add much value, and we shouldn't depend on the trust code for this (more likely it should've been the other way round)

@thaJeztah
thaJeztah requested review from a team and BenehikoMarch 3, 2025 11:25
@codecov-commenter

codecov-commenter commented Mar 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.31%. Comparing base (076ec3b) to head (e3da0cc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #5880 +/- ##
=======================================
Coverage 59.31% 59.31% =======================================
Files 353 353 Lines 29735 29735 =======================================
Hits 17637 17637 Misses 11117 11117 Partials 981 981 

@thaJeztah
thaJeztah merged commit 43a2fcf into docker:masterMar 3, 2025
@thaJeztah
thaJeztah deleted the registry_decouple_trust branch March 3, 2025 11:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/distributionkind/refactorPR's that refactor, or clean-up codestatus/2-code-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-commenter@vvoland@Benehiko