Uh oh!
There was an error while loading. Please reload this page.
cli/command: deprecate CopyToFile and reimplement with atomicwriter - #5914
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #5914 +/- ##
==========================================
+ Coverage 59.12% 59.16% +0.04%
==========================================
Files 355 355 Lines 29740 29733 -7 ==========================================
+ Hits 17583 17591 +8 + Misses 11182 11168 -14 + Partials 975 974 -1 🚀 New features to boost your workflow:
|
thaJeztahforce-pushed
the
use_atomicwriter
branch
4 times, most recently
from
March 25, 2025 10:50
5e6b61d to
64a2e41ComparethaJeztahforce-pushed
the
use_atomicwriter
branch
4 times, most recently
from
April 4, 2025 21:11
5e54fa9 to
7d1f7bfCompareSame functionality, but implemented with atomicwriter. There's a slight difference in error-messages produced (but can be adjusted if we want). Before: docker image save -o ./no/such/foo busybox:latest failed to save image: invalid output path: directory "no/such" does not exist docker image save -o /no/permissions busybox:latest failed to save image: stat /no/permissions: permission denied After: docker image save -o ./no/such/foo busybox:latest failed to save image: invalid file path: stat no/such: no such file or directory docker image save -o /no/permissions busybox:latest failed to save image: failed to stat output path: lstat /no/permissions: permission denied Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Same functionality, but implemented with atomicwriter. There's a slight difference in error-messages produced (but can be adjusted if we want). Before: docker container export -o ./no/such/foo mycontainer failed to export container: invalid output path: directory "no/such" does not exist docker container export -o /no/permissions mycontainer failed to export container: stat /no/permissions: permission denied After: docker container export -o ./no/such/foo mycontainer failed to export container: invalid file path: stat no/such: no such file or directory docker container export -o /no/permissions mycontainer failed to export container: failed to stat output path: lstat /no/permissions: permission denied Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
use_atomicwriter
branch
from
April 10, 2025 07:46
a3a4f5d to
7cc6b8eComparethaJeztah
marked this pull request as ready for review
April 10, 2025 07:47
thaJeztah
commented
Apr 10, 2025
MemberAuthor
thaJeztah
commented
Apr 10, 2025
Comment on lines
+28
to
29
| // Deprecated: use [atomicwriter.New]. | ||
| func CopyToFile(outfile string, r io.Reader) error { |
MemberAuthor
There was a problem hiding this comment.
This was used in compose, but has been removed there in docker/compose#12715
Benehiko
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)