Uh oh!
There was an error while loading. Please reload this page.
[WIP] untangling auth-related code - #5925
Draft
thaJeztah wants to merge 2 commits into
Draft
Conversation
thaJeztah
commented
Mar 12, 2025
MemberAuthor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
thaJeztahforce-pushed
the
simplify_auth
branch
3 times, most recently
from
March 19, 2025 14:37
df692c7 to
8a4f9b4ComparethaJeztahforce-pushed
the
simplify_auth
branch
4 times, most recently
from
March 25, 2025 12:25
074b5a7 to
c784802ComparethaJeztahforce-pushed
the
simplify_auth
branch
3 times, most recently
from
April 4, 2025 19:52
a3f954e to
26845e4ComparethaJeztahforce-pushed
the
simplify_auth
branch
3 times, most recently
from
April 17, 2025 14:21
199969d to
76452e7ComparethaJeztahforce-pushed
the
simplify_auth
branch
6 times, most recently
from
July 25, 2025 21:27
c2f0f43 to
62c8255ComparethaJeztahforce-pushed
the
simplify_auth
branch
11 times, most recently
from
August 25, 2025 14:25
5d6bc2b to
b8dfa73ComparethaJeztahforce-pushed
the
simplify_auth
branch
7 times, most recently
from
September 1, 2025 08:38
6d48c2e to
6e8a0d3ComparethaJeztahforce-pushed
the
simplify_auth
branch
2 times, most recently
from
September 8, 2025 15:46
b8ad44d to
356d269ComparethaJeztahforce-pushed
the
simplify_auth
branch
2 times, most recently
from
September 26, 2025 08:10
7e6bd69 to
45e453cComparethaJeztahforce-pushed
the
simplify_auth
branch
3 times, most recently
from
September 26, 2025 17:28
0657183 to
2fdb78aCompareLots to do here; too many wrappers everywhere, which may become easier when content trust is removed (which adds another level of abstraction) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really (REALLY) work in progress; slowly untangling some of the auth-code which was wrapper-upon-wrapper-upon-wrapper; often because types like
registry.IndexInfoorregistry.RepositoryInfowere part of the signature.Docker Content Trust added yet-another layer of abstraction on top of that, with
trust.ImageRefAndAuth, which is a wrapper on its own to wrap all those bits.In most cases, all we need is;
And of course, there's the "special cases" for docker hub;
docker.ioorindex.docker.ioPREFIX means "docker hub registry" (actual registry isregistry-1.docker.io(but there's other domains possiblehttps://index.docker.io/v1/as KEY to store credentials for thoseBut there's more to untangle, such as creds-helpers/stores converting "to hostname", but other paths don't, and likely corner-cases, where (e.g.) a trailing
/is missing inhttps://index.docker.io/v1/, etc etc.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)