Uh oh!
There was an error while loading. Please reload this page.
test/cli-plugins: Attempt to make TestConnectAndWait less flaky - #5932
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #5932 +/- ##
==========================================
- Coverage 59.33% 59.28% -0.05%
==========================================
Files 358 358 Lines 29783 29830 +47 ==========================================
+ Hits 17672 17685 +13 - Misses 11142 11173 +31 - Partials 969 972 +3 🚀 New features to boost your workflow:
|
Benehiko
left a comment
Member
There was a problem hiding this comment.
This test might still flake now and again. It's impossible to know exactly how the Go runtime will start/cleanup the goroutine.
go test -race -run=TestConnectAndWait/connect_goroutine_exits_after_EOF -count=10000 -failfast -v ./cli-plugins/socket/......=== RUN TestConnectAndWait/connect_goroutine_exits_after_EOF socket_test.go:192: timeout hit after 500ms: waiting for connect goroutine to spawn--- FAIL: TestConnectAndWait (0.50s) --- FAIL: TestConnectAndWait/connect_goroutine_exits_after_EOF (0.50s)FAILFAIL github.com/docker/cli/cli-plugins/socket 7.490sFAILvvolandforce-pushed
the
TestConnectAndWait-flaky
branch
from
March 17, 2025 13:39
88fbbcc to
36a6b7eComparevvolandforce-pushed
the
TestConnectAndWait-flaky
branch
from
March 17, 2025 13:40
36a6b7e to
413bb2bComparevvoland
commented
Mar 17, 2025
CollaboratorAuthor
Hmm right, I think we can still make it a little bit stable by locking the test goroutine to its own thread. $ go test -run=TestConnectAndWait/connect_goroutine_exits_after_EOF -count=1000000 ./cli-plugins/socket/... --- FAIL: TestConnectAndWait (0.50s)
--- FAIL: TestConnectAndWait/connect_goroutine_exits_after_EOF (0.50s)
socket_test.go:196: timeout hit after 500ms: waiting for connect goroutine to spawn
--- FAIL: TestConnectAndWait (0.51s)
--- FAIL: TestConnectAndWait/connect_goroutine_exits_after_EOF (0.51s)
socket_test.go:196: timeout hit after 500ms: waiting for connect goroutine to spawn
FAIL
FAIL github.com/docker/cli/cli-plugins/socket 461.944s
FAIL2 flakes per million runs still seems much better, while still keeping the test. |
| // relying on goroutine numbers to ensure correct behaviour | ||
| t.Run("connect goroutine exits after EOF", func(t *testing.T) { | ||
| runtime.LockOSThread() | ||
| defer runtime.LockOSThread() |
Member
There was a problem hiding this comment.
I'm guessing this was meant to be
Suggested change
| deferruntime.LockOSThread() | |
| deferruntime.UnlockOSThread() |
- Add runtime.Gosched() calls to encourage goroutine scheduling - Increase the timeout from 10ms to 500ms - Use poll.WaitOn with appropriate delays to ensure the goroutine has spawned before checking - Lock the test goroutines to its own thread Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvolandforce-pushed
the
TestConnectAndWait-flaky
branch
from
March 19, 2025 10:52
413bb2b to
0ce8989Comparevvoland
commented
Mar 19, 2025
CollaboratorAuthor
With |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawned before checking
- How to verify it
Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com